New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update AWS-SDK-GO to >= version 1.29.11 #41
Conversation
Signed-off-by: Paul Jones <paul.jones.nmet@statefarm.com>
Signed-off-by: Paul Jones <paul.jones.nmet@statefarm.com>
Thanks for the PR @jones-paul1525! This looks fine to me. Were you able to test this change by any chance? |
Other than basic tests to make sure it still builds, I have not been able to test. I will see if it is a possibility for me to test this change within my organization's development sandbox. Thank you! |
👍 if anyone else has the bandwidth to help out with a quick smoke test on this, that'd be great. cc @nrb @carlisia @ashish-amarnath |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change looks good but I would like to get a basic smoke test done before merge.
Can do this sometime today or tomorrow. |
I was able to verify the object store plugin. To verify the volumesnapshotter plugin I need more time to verify the volumesnapshotting. |
I think if it compiles and the object store works fine, then we're probably OK. |
I am OK with merging this. |
Thanks for you PR @jones-paul1525 |
Update the version of the Amazon AWS SDK that the plugin is using to a version that has support for connecting to regional STS endpoints - and by extension, private VPC STS endpoints, to authenticate using Amazon's recommended method - IAM Roles for Service Accounts. This will allow EKS clusters that do not have access to the internet to run Velero and configure it to use the private VPC STS endpoint for authentication.