Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor image builds to use buildx for multi arch image building #70

Closed
wants to merge 1 commit into from
Closed

Refactor image builds to use buildx for multi arch image building #70

wants to merge 1 commit into from

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Jan 5, 2021

Proposed Changes

  • Refactor the images build to use docker buildx for the multi-arch image build
  • Bump Go to 1.15

Types of Changes

  • Dockerfile
  • Makefile
  • CI/CD

Verification

Follow the Build from source

  1. The following build commands work:
REGISTRY=jenting BUILDX_OUTPUT_TYPE=registry make container

BUILDX_PLATFORMS=linux/arm64 make container

REGISTRY=jenting VERSION=test BUILDX_PLATFORMS=linux/amd64,linux/arm64,linux/arm/v7,linux/ppc64le BUILDX_OUTPUT_TYPE=registry make all-containers
  1. I have done a test on .github/workflows/push.yml with a hack push to my docker hub account, it works correctly.

  2. I have deployed the velero-plugin-for-aws on amd64 and arm64 machines from step 2 result, both work correctly.

Linked Issues

Fixes vmware-tanzu/velero#3139

Further Comments

Ref to vmware-tanzu/velero#2754

@jenting jenting added the enhancement New feature or request label Jan 5, 2021
@carlisia
Copy link
Contributor

@jenting couple things:

  • sorry for taking long to get to review this, but I'm sure we're only going to get around to it after we ship v1.6
  • we were (recently) authorized to not use the year in the copyright. So please use Copyright the Velero contributors. going forward. We are looking forward to not having to update that header anymore at some point. Thanks.

Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
@jenting jenting requested a review from carlisia May 20, 2021 01:29
@jenting
Copy link
Contributor Author

jenting commented May 20, 2021

@jenting couple things:

  • sorry for taking long to get to review this, but I'm sure we're only going to get around to it after we ship v1.6
  • we were (recently) authorized to not use the year in the copyright. So please use Copyright the Velero contributors. going forward. We are looking forward to not having to update that header anymore at some point. Thanks.

@carlisia Could you please take a look? Thanks.

@jenting jenting requested review from dsu-igeek and removed request for ashish-amarnath June 18, 2021 00:54
@jenting jenting removed the request for review from carlisia July 23, 2021 15:29
@jenting
Copy link
Contributor Author

jenting commented Feb 15, 2022

Use #103 to tackle this.
Close it.

@jenting jenting closed this Feb 15, 2022
@jenting jenting deleted the docker-buildx branch February 15, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants