Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #94

Closed
wants to merge 1 commit into from
Closed

Update README.md #94

wants to merge 1 commit into from

Conversation

a-mccarthy
Copy link
Contributor

@a-mccarthy
Copy link
Contributor Author

@zubron requesting your review here since you had a comment mentioned in the original issue. Feel free to re-assign someone else for review :)

Is this issue specific to using EKS?

Copy link
Collaborator

@sseago sseago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit needs the signoff ( https://github.com/vmware-tanzu/velero-plugin-example/blob/main/CONTRIBUTING.md#dco-sign-off ) but otherwise, this looks good.

@a-mccarthy
Copy link
Contributor Author

@sseago thanks for reviewing this. I ended up opening a new PR, #97, for this bc I realized made a new branch right on the repo instead of from a fork. Can you take a look at the new PR and approve? its the same, except with the correct signoff :)

@a-mccarthy a-mccarthy closed this Jan 4, 2022
@a-mccarthy a-mccarthy deleted the a-mccarthy-patch-1 branch January 4, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants