clarify the wording for restore describe for namespaces included (#2449)

* clarify the wording for restore describe for namespaces included Instead of showing it as "*" explicitly mention that all the namespaces from the backup object are included. refer to #1918 Signed-off-by: Raghavendra M <raghavendra@redhat.com> * Update pkg/cmd/util/output/restore_describer.go Co-Authored-By: Ashish Amarnath <ashisham@vmware.com> Signed-off-by: Raghavendra M <raghavendra@redhat.com> * Update pkg/cmd/util/output/restore_describer.go Co-Authored-By: Ashish Amarnath <ashisham@vmware.com> Signed-off-by: Raghavendra M <raghavendra@redhat.com> Co-authored-by: Ashish Amarnath <ashisham@vmware.com>
vmware-tanzu · Apr 24, 2020 · 98d2fc7 · 98d2fc7
1 parent 962f5d6
commit 98d2fc7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/changelogs/unreleased/1918-raghavendrabhat b/changelogs/unreleased/1918-raghavendrabhat
@@ -0,0 +1,4 @@
+clarify the wording for restore describe for namespaces included
+
+Instead of showing it as "*" explicitly mention that all the namespaces
+from the backup object are included.
diff --git a/pkg/cmd/util/output/restore_describer.go b/pkg/cmd/util/output/restore_describer.go
@@ -65,7 +65,9 @@ func DescribeRestore(restore *v1.Restore, podVolumeRestores []v1.PodVolumeRestor
 		d.Printf("Namespaces:\n")
 		var s string
 		if len(restore.Spec.IncludedNamespaces) == 0 {
-			s = "*"
+			s = "all namespaces found in the backup"
+		} else if len(restore.Spec.IncludedNamespaces) == 1 && restore.Spec.IncludedNamespaces[0] == "*" {
+			s = "all namespaces found in the backup"
 		} else {
 			s = strings.Join(restore.Spec.IncludedNamespaces, ", ")
 		}