clarify the wording for restore describe for namespaces included #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlisia
reviewed
Apr 23, 2020
|
@carlisia what you requested for seems fair to me. I added in suggestions for faster turnaround :) |
Instead of showing it as "*" explicitly mention that all the namespaces from the backup object are included. refer to vmware-tanzu#1918 Signed-off-by: Raghavendra M <raghavendra@redhat.com>
Co-Authored-By: Ashish Amarnath <ashisham@vmware.com> Signed-off-by: Raghavendra M <raghavendra@redhat.com>
Co-Authored-By: Ashish Amarnath <ashisham@vmware.com> Signed-off-by: Raghavendra M <raghavendra@redhat.com>
raghavendrabhat
force-pushed
the
master-pull-request-velero-restore-describe
branch
from
2ac1ce1
to
4f6275d
Compare
skriss
approved these changes
Apr 24, 2020
ashish-amarnath
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of showing it as "*" explicitly mention that all the namespaces
from the backup object are included.
refer to #1918
Signed-off-by: Raghavendra M raghavendra@redhat.com