Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CI check for changelog file #2476

Closed
skriss opened this issue Apr 29, 2020 · 0 comments · Fixed by #2613
Closed

Add a CI check for changelog file #2476

skriss opened this issue Apr 29, 2020 · 0 comments · Fixed by #2613
Labels
CI/CD Enhancement/Dev Internal or Developer-focused Enhancement to Velero Good first issue Looking to contribute to Velero? Issues with this label might be a great place to start! Help wanted
Milestone

Comments

@skriss
Copy link
Member

skriss commented Apr 29, 2020

We should add a CI check for a changelog file. I think it should be required by default, perhaps unless the PR is explicitly labeled with a no-changelog-required label. This would make it easier for contributors and reviewers alike.

We probably also want to add a PR template with instructions about DCO and the changelog file, to help new contributors understand.

@skriss skriss added Enhancement/Dev Internal or Developer-focused Enhancement to Velero CI/CD labels Apr 29, 2020
@skriss skriss added this to the v1.5 milestone May 1, 2020
@skriss skriss added P2 - Long-term important Help wanted Good first issue Looking to contribute to Velero? Issues with this label might be a great place to start! labels May 28, 2020
@nrb nrb closed this as completed in #2613 Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Enhancement/Dev Internal or Developer-focused Enhancement to Velero Good first issue Looking to contribute to Velero? Issues with this label might be a great place to start! Help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant