add support for getting Azure Storage Account key from ENV variable #2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Odstrcilik <martin.odstrcilik@gmail.com>
|
@jaygridley this looks good to me - can you just add a changelog file ( |
|
@jaygridley gentle reminder that we're just waiting on a changelog file from you here. Thanks! |
|
👆 |
|
I'd say let's merge this and I'll add a changelog file in a separate PR. |
skriss
approved these changes
May 1, 2020
skriss
added a commit
to skriss/velero
that referenced
this pull request
May 1, 2020
Signed-off-by: Steve Kriss <krisss@vmware.com>
|
changelog PR added: #2491 let's get these merged! |
|
also note I added #2476 to the backlog |
carlisia
approved these changes
May 1, 2020
|
Sorry guys. I was out with proper access. Is there any work needed? |
|
nope, we took care of it. thanks for the PR! |
ashish-amarnath
pushed a commit
that referenced
this pull request
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #2376.