Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify the wording for restore describe for namespaces included #2449

Merged
merged 3 commits into from
Apr 24, 2020
Merged

clarify the wording for restore describe for namespaces included #2449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed11256
clarify the wording for restore describe for namespaces included
raghavendrabhat Apr 20, 2020
2550a40
Update pkg/cmd/util/output/restore_describer.go
raghavendrabhat Apr 24, 2020
4f6275d
Update pkg/cmd/util/output/restore_describer.go
raghavendrabhat Apr 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelogs/unreleased/1918-raghavendrabhat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
clarify the wording for restore describe for namespaces included

Instead of showing it as "*" explicitly mention that all the namespaces
from the backup object are included.
4 changes: 3 additions & 1 deletion pkg/cmd/util/output/restore_describer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ func DescribeRestore(restore *v1.Restore, podVolumeRestores []v1.PodVolumeRestor
d.Printf("Namespaces:\n")
var s string
if len(restore.Spec.IncludedNamespaces) == 0 {
s = "*"
s = "all namespaces found in the backup"
} else if len(restore.Spec.IncludedNamespaces) == 1 && restore.Spec.IncludedNamespaces[0] == "*" {
s = "all namespaces found in the backup"
} else {
s = strings.Join(restore.Spec.IncludedNamespaces, ", ")
}
Expand Down