-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix status.progress not getting updated for backup #6276
Fix status.progress not getting updated for backup #6276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the modification according to the comments.
Thank you @blackpiglet, I have update PR by addressing review comments |
Signed-off-by: kkothule <kkothule@catalogicsoftware.com>
@Lyndon-Li , @shubham-pampattiwar please review |
@kkothule pl fix the linting |
@anshulahuja98 The file pkg/backup/backup_pv_action.go is not part of my PR, Should i still go ahead and fix the issue? |
Codecov Report
@@ Coverage Diff @@
## main #6276 +/- ##
==========================================
- Coverage 41.20% 40.99% -0.22%
==========================================
Files 252 255 +3
Lines 23503 23818 +315
==========================================
+ Hits 9684 9763 +79
- Misses 13061 13293 +232
- Partials 758 762 +4
|
7fa9106
into
vmware-tanzu:main
In today's community call, we discussed about back-porting this PR to 1.11 as it fixes a high impact problem. @sseago mentioned that there is no clearly defined process for selecting fixes for back-porting, as there is for major releases. One solution is to require two or more maintainers to agree to back-port. As that process is discussed, it would be nice if we can make a decision about this particular issue being part of 1.11.1. CC @blackpiglet @shubham-pampattiwar @weshayutin. |
@draghuram Actually, we just merged that today: #6324 |
@draghuram |
Great. Thanks. |
Thank you for contributing to Velero!
Please add a summary of your change
Fixed a bug where status.progress is not getting updated for backups.
Does your change fix a particular issue?
Fixes #6275
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.