Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick][release-1.11]Fix status.progress not getting updated for backup #6324

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented May 30, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #6275

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@blackpiglet blackpiglet self-assigned this May 30, 2023
@blackpiglet blackpiglet changed the title Fix status.progress not getting updated for backup [cherry-pick][release-1.11]Fix status.progress not getting updated for backup May 30, 2023
Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
@blackpiglet blackpiglet force-pushed the 6276_cherry_pick_release_1.11 branch from 8774f26 to 7dccc17 Compare May 30, 2023 07:47
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2023

Codecov Report

Merging #6324 (7dccc17) into release-1.11 (dc0a712) will decrease coverage by 0.02%.
The diff coverage is 54.16%.

@@               Coverage Diff                @@
##           release-1.11    #6324      +/-   ##
================================================
- Coverage         41.31%   41.29%   -0.02%     
================================================
  Files               251      251              
  Lines             23405    23419      +14     
================================================
+ Hits               9669     9671       +2     
- Misses            12978    12989      +11     
- Partials            758      759       +1     
Impacted Files Coverage Δ
pkg/backup/backup.go 52.07% <54.16%> (-0.06%) ⬇️

... and 1 file with indirect coverage changes

@blackpiglet blackpiglet marked this pull request as ready for review May 30, 2023 11:48
@shubham-pampattiwar shubham-pampattiwar merged commit ba8465b into vmware-tanzu:release-1.11 May 30, 2023
25 checks passed
@ShellyKa13
Copy link

Hi when are you planning on releasing 1.11.1 with this fix?

@blackpiglet
Copy link
Contributor Author

@ShellyKa13
The current plan is to release v1.11.1 around this September's end.
Need to wait a while to collect more PRs, and also need to wait for the new patch of Golang v1.20.x to fix CVEs.
What's your opinion about this arrangement?

@ShellyKa13
Copy link

ShellyKa13 commented Jun 15, 2023

wasn't prepared for such a long period :) I have tests which relay on the status progress report. I will check if downgrading back to 1.10 will fix the issue since I wont wait until September. thanks

@blackpiglet
Copy link
Contributor Author

@ShellyKa13
Sorry, I made a mistake. The release time is not that long behind. v1.11.1 is planned to release at the end of next weekend.

@ShellyKa13
Copy link

@blackpiglet hi thanks for the update, so I am waiting for it, any new update on expected release date? thanks

@blackpiglet
Copy link
Contributor Author

@ShellyKa13
Sorry, v1.11.1 is delayed.
https://groups.google.com/g/golang-announce/c/q5135a9d924
Due to Golang v1.20.5 issue, need to wait for Golang v1.20.6 to come out to release Velero v1.11.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants