Fix for #50 #52
Merged
Fix for #50 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should resolve the issue described by: #50 Cause: Use of AND condition instead of OR condition means that user must be using a free Burp version AND have also not specified a project file. However, this ignores two cases: 1. The user mistakenly states a project file with Burp free edition 2. The user does not state a project file with Burp paid edition Both of these cases require the creation of an empty projectData array. Resolution: Changed conditional operator from `&&` to `||`. I also rearranged the operands so that the `Note:` line flows into the logic of the if-statement. "Burp Free does not support project..." => "`if (!burpEdition.equalsIgnoreCase('free')`"
|
@lazorgator, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
|
I was not able to personally test these changes, so someone definitely should before the merge. While I was checking out the library to use in a project, I noticed this rather serious bug and fixed it, but am not in a position to test it at the moment. |
|
@lazorgator, VMware has approved your signed contributor license agreement. |
This was referenced Aug 31, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve the issue described by: #50
Cause
Use of AND condition instead of OR condition means that user must be using a free Burp version AND have also not specified a project file.
However, this ignores two cases:
Both of these cases require the creation of an empty projectData array.
Resolution
Changed conditional operator from
&&to||.I also rearranged the operands so that the
Note:line flows into the logic of the if-statement."Burp Free does not support project..." => "
if (!burpEdition.equalsIgnoreCase('free')"