Better Fix #50 and #46 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a bit of info on -PappArgs option
|
@adracea, VMware has approved your signed contributor license agreement. |
|
I've tested these and made the changes according to my "field" data . Burp free edition was started successfully in an Arch VM box and Burp Pro works quite fine with the new added options in 975afa8 for project file loading . |
|
I will review soon and merge. Btw, we're removing Burp free support thus you may want to update your PR as soon as the change is in master. |
|
Burp Free/Community is now deprecated. See #71 If you can adjust this pull request, I will merge your change to master. Thanks again for the contribution! |
|
Hey there , I'll look through it tonight and update first thing tomorrow
morning . Shouldn't be that much though :)
…On Tue, 23 Oct 2018, 22:42 Luca Carettoni, ***@***.***> wrote:
Burp Free/Community is now deprecated. See #71
<#71>
If you can adjust this pull request, I will merge your change to master.
Thanks again for the contribution!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#63 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF7UB5QgMNL70t_1oVEbwzb4DriU13PJks5un3EngaJpZM4WVIf6>
.
|
|
Okay , should be good now :D I reverted the commits to burpservice.java since those were the only blockers :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds :
-PappArgs="['arg1','arg2','arg3']"to be able to pass arguments to burp suite directly via the gradle wrapper (gradlew bootRun -PappArgs="['--project-file=./test.burp','--config-file=./cfg.json','--user-config-file=./usr-cfg.json']").&&