-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Behavior support to Defined Interfaces and Defined Entity Types #584
Add Behavior support to Defined Interfaces and Defined Entity Types #584
Conversation
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few inline questions. Lots of boilerplate - which is sort of a good thing :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few queries as this is a lot of boilerplate. Will have to think in future on how to reduce code for standardized endpoints like these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found it confusing to see "override" being used as a noun and as a verb in the same scope. (It's hard to tell whether it's a noun or verb in English with little context). So, I have added a suggestion to use a noun through out.
Signed-off-by: abarreiro <abarreiro@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the adjustment!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rde
tests passed
Signed-off-by: abarreiro <abarreiro@vmware.com>
Overview
This PR serves as the foundations of vmware/terraform-provider-vcd#1074
It adds methods to both Defined Interface and Defined Entity Type types to manage Behaviors and Behavior Access Controls.
Context
Behaviors are explained here, but in simplified words, they're "procedures" that belong to RDE Interfaces, are inherited by the RDE Types that use those Interfaces and are invoked on the RDEs that instantiate those types.
Also, Behaviors can be overridden at the RDE Type level. For example, if you use a RDE Interface with behavior "A", you can override what it does in a Type that uses it.
Also, Behaviors have "Access Levels", which can define what operations can be done in that behavior.