Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code for Solution Landing Zone management [1] #665

Merged
merged 11 commits into from
May 17, 2024

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Apr 11, 2024

This PR adds support for managing Solution Landing Zones on VCD 10.4.1+

@Didainius Didainius force-pushed the split-pr-dse-landing branch 2 times, most recently from 106079f to c71428b Compare April 11, 2024 12:00
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius changed the title WIP: Add code for Solution Landing Zone management Add code for Solution Landing Zone management Apr 15, 2024
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius marked this pull request as ready for review May 7, 2024 12:06
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one polishing comment.

govcd/landing_zone.go Outdated Show resolved Hide resolved
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First scan, didn't run tests yet.

govcd/landing_zone.go Outdated Show resolved Hide resolved
govcd/landing_zone.go Show resolved Hide resolved
govcd/landing_zone.go Outdated Show resolved Hide resolved
govcd/landing_zone.go Show resolved Hide resolved
govcd/landing_zone.go Outdated Show resolved Hide resolved
govcd/landing_zone.go Show resolved Hide resolved
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
govcd/landing_zone.go Outdated Show resolved Hide resolved
.changes/v2.24.0/665-features.md Outdated Show resolved Hide resolved
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius changed the title Add code for Solution Landing Zone management Add code for Solution Landing Zone management [1] May 14, 2024
@Didainius Didainius merged commit 4913d51 into vmware:main May 17, 2024
2 checks passed
@Didainius Didainius deleted the split-pr-dse-landing branch May 17, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants