Solution Add-On upload [2] #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
changed the title
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
commented
May 20, 2024
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
lvirbalas
approved these changes
May 20, 2024
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
dataclouder
reviewed
Jun 7, 2024
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
dataclouder
approved these changes
Jun 7, 2024
adambarreiro
approved these changes
Jun 7, 2024
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues on top of #665 and adds management of Solution Add-Ons within a Solution Landing Zone.
To create a Solution Add-on, one must have a Solution Add-On image. Due to the architecture of Solution Add-Ons it must be present both - locally and and also uploaded to the catalog.
A local copy is needed to extract the image and pick required metadata - such as icon, EULA, certificate and Add-On type, while a copy in the VCD catalog will be used to create Solution Add-On instances later.
Testing
Testing VCD environment is expected to have an image uploaded already to
nsxtBackedCatalogNameand name of it must be specified innsxtCatalogAddonDsevariable. TheTest_SolutionAddOntest will automatically check if the image is present locally within/test-resources/cachesubdirectory (which is also added to.gitignore) - if it is not found - it will download the file from VCD catalog as defined innsxtCatalogAddonDsevariableTested on 10.4.1 and 10.5.1