Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vm extra configuration #666

Merged
merged 11 commits into from
May 14, 2024
Merged

Vm extra configuration #666

merged 11 commits into from
May 14, 2024

Conversation

dataclouder
Copy link
Contributor

Add VM methods GetExtraConfig, UpdateExtraConfig, and DeleteExtraConfig to manage VM extra configuration

Didainius and others added 5 commits March 19, 2024 10:00
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
…ud-director into vm-extra-config

Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
WIP
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Giuseppe Maxia added 2 commits April 17, 2024 06:12
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder dataclouder marked this pull request as ready for review April 18, 2024 08:16
@dataclouder dataclouder requested a review from arunmk April 18, 2024 08:17
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

govcd/vm_test.go Outdated Show resolved Hide resolved
Giuseppe Maxia added 2 commits April 22, 2024 08:27
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR number, LGTM

Giuseppe Maxia added 2 commits May 14, 2024 08:36
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
Signed-off-by: Giuseppe Maxia <giuseppe.maxia@broadcom.com>
@dataclouder dataclouder merged commit 85e22f8 into vmware:main May 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants