Skip to content

Commit

Permalink
Merge pull request #2621 from dougm/event-manager-reference
Browse files Browse the repository at this point in the history
Implement mo.Reference interface in task+event managers
  • Loading branch information
dougm committed Oct 13, 2021
2 parents ffd45c8 + d5ded1f commit df705a2
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 0 deletions.
4 changes: 4 additions & 0 deletions event/example_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,13 @@ import (
"github.com/vmware/govmomi/find"
"github.com/vmware/govmomi/simulator"
"github.com/vmware/govmomi/vim25"
"github.com/vmware/govmomi/vim25/mo"
"github.com/vmware/govmomi/vim25/types"
)

// ensure event.Manager implements the mo.Reference interface
var _ mo.Reference = new(event.Manager)

func ExampleManager_Events() {
simulator.Run(func(ctx context.Context, c *vim25.Client) error {
m := event.NewManager(c)
Expand Down
5 changes: 5 additions & 0 deletions event/manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ func NewManager(c *vim25.Client) *Manager {
return &m
}

// Reference returns the event.Manager MOID
func (m Manager) Reference() types.ManagedObjectReference {
return m.r
}

func (m Manager) Client() *vim25.Client {
return m.c
}
Expand Down
5 changes: 5 additions & 0 deletions task/manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ func NewManager(c *vim25.Client) *Manager {
return &m
}

// Reference returns the task.Manager MOID
func (m Manager) Reference() types.ManagedObjectReference {
return m.r
}

// CreateCollectorForTasks returns a task history collector, a specialized
// history collector that gathers TaskInfo data objects.
func (m Manager) CreateCollectorForTasks(ctx context.Context, filter types.TaskFilterSpec) (*HistoryCollector, error) {
Expand Down
4 changes: 4 additions & 0 deletions task/wait_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,13 @@ package task
import (
"testing"

"github.com/vmware/govmomi/vim25/mo"
"github.com/vmware/govmomi/vim25/types"
)

// ensure task.Manager implements the mo.Reference interface
var _ mo.Reference = new(Manager)

func TestCallbackFn(t *testing.T) {
cb := &taskCallback{}

Expand Down

0 comments on commit df705a2

Please sign in to comment.