Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement mo.Reference interface in task+event managers #2621

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

dougm
Copy link
Member

@dougm dougm commented Oct 13, 2021

Description

Prior to #2535 both managers implemented mo.Reference via the embedded 'object.Common' field,
but that field was removed.

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

Checklist:

  • My code follows the CONTRIBUTION guidelines of
    this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Prior to vmware#2535 both managers implemented mo.Reference via the embedded 'object.Common' field,
but that field was removed.
@dougm dougm merged commit df705a2 into vmware:master Oct 13, 2021
@dougm dougm deleted the event-manager-reference branch October 13, 2021 22:48
@zach96guan
Copy link
Member

The fix LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants