Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Requesting SSO user/group modification feature (on par with govc's) #2852

Closed
dbuenoparedes opened this issue May 19, 2022 · 2 comments · Fixed by #3051
Closed

[FR] Requesting SSO user/group modification feature (on par with govc's) #2852

dbuenoparedes opened this issue May 19, 2022 · 2 comments · Fixed by #3051
Labels
kind/feature lifecycle/frozen

Comments

@dbuenoparedes
Copy link

Is your feature request related to a problem? Please describe.
While looking at vcsim to do some user/group creation automation testing I noticed that only a few of the SSO features are implemented in vcsim but not user/group creation. Here are two examples of the API calls using govc commands:

govc-test sso.user.ls
/govc: ServerFaultCode: managed object not found: SsoAdminPrincipalDiscoveryService:principalDiscoveryService

govc-test sso.group.ls
/govc: ServerFaultCode: managed object not found: SsoAdminPrincipalDiscoveryService:principalDiscoveryService

output of each command in vcsim docker container:

2022/05/19 19:38:39 managed object not found: SsoAdminPrincipalDiscoveryService:principalDiscoveryService

2022/05/19 19:39:06 managed object not found: SsoAdminPrincipalDiscoveryService:principalDiscoveryService

Describe the solution you'd like
Having the sso API calls that govc provides available in vcsim as well:

  sso.group.create
  sso.group.ls
  sso.group.rm
  sso.group.update
  sso.idp.ls
  sso.service.ls
  sso.user.create
  sso.user.id
  sso.user.ls
  sso.user.rm
  sso.user.update

Describe alternatives you've considered
Only alternative I can think of is using an actual vCenter server instance to test the SSO user/group creation.

Additional context
Thank you for creating this vcsim tool, it is really really helpful for testing things out without requiring a actual vCenter server instance. I'm using the container flavor but I'm sure the other flavors are similarly useful to the community.
@github-actions
Copy link
Contributor

Howdy 🖐   dbuenoparedes ! Thank you for your interest in this project. We value your feedback and will respond soon.

If you want to contribute to this project, please make yourself familiar with the CONTRIBUTION guidelines.

@dbuenoparedes dbuenoparedes changed the title Requesting SSO user/group modification feature (on par with govc's) [FR] Requesting SSO user/group modification feature (on par with govc's) May 19, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Mark as fresh by adding the comment /remove-lifecycle stale.

@dougm dougm reopened this Feb 14, 2023
dougm added a commit to dougm/govmomi that referenced this issue Feb 20, 2023
@dougm
vcsim: add ssoadmin user and group management
1c30fee 
The ssoadmin endpoint is now used for authentication for both SOAP and REST endpoints.
Previous behavior is retained:
- By default, any non-empty username + password is authenticated
- If vcsim '-username' and '-password' flags are given, only those credentials can be used for authentication

Additional users can be added via the ssoadmin APIs or using govc for example:

  % govc sso.user.create -p password govc

Closes vmware#2852
@dougm dougm mentioned this issue Feb 20, 2023
Merged
11 tasks
dougm added a commit to dougm/govmomi that referenced this issue Feb 20, 2023
@dougm
vcsim: add ssoadmin user and group management
0133d73 
The ssoadmin endpoint is now used for authentication for both SOAP and REST endpoints.
Previous behavior is retained:
- By default, any non-empty username + password is authenticated
- If vcsim '-username' and '-password' flags are given, only those credentials can be used for authentication

Additional users can be added via the ssoadmin APIs or using govc for example:

  % govc sso.user.create -p password govc

Closes vmware#2852
dougm added a commit to dougm/govmomi that referenced this issue Mar 18, 2023
@dougm
vcsim: add ssoadmin user and group management
5f8639f 
The ssoadmin endpoint is now used for authentication for both SOAP and REST endpoints.
Previous behavior is retained:
- By default, any non-empty username + password is authenticated
- If vcsim '-username' and '-password' flags are given, only those credentials can be used for authentication

Additional users can be added via the ssoadmin APIs or using govc for example:

  % govc sso.user.create -p password govc

Closes vmware#2852
dougm added a commit to dougm/govmomi that referenced this issue Mar 18, 2023
@dougm
vcsim: add ssoadmin user and group management
c62983f 
The ssoadmin endpoint is now used for authentication for both SOAP and REST endpoints.
Previous behavior is retained:
- By default, any non-empty username + password is authenticated
- If vcsim '-username' and '-password' flags are given, only those credentials can be used for authentication

Additional users can be added via the ssoadmin APIs or using govc for example:

  % govc sso.user.create -p password govc

Closes vmware#2852
dougm added a commit that referenced this issue Jun 27, 2023
@dougm
vcsim: add ssoadmin user and group management
d46fe80 
The ssoadmin endpoint is now used for authentication for both SOAP and REST endpoints.
Previous behavior is retained:
- By default, any non-empty username + password is authenticated
- If vcsim '-username' and '-password' flags are given, only those credentials can be used for authentication

Additional users can be added via the ssoadmin APIs or using govc for example:

  % govc sso.user.create -p password govc

Closes #2852
priyanka19-98 pushed a commit to priyanka19-98/govmomi that referenced this issue Jan 17, 2024
@dougm
vcsim: add ssoadmin user and group management
760e19d 
The ssoadmin endpoint is now used for authentication for both SOAP and REST endpoints.
Previous behavior is retained:
- By default, any non-empty username + password is authenticated
- If vcsim '-username' and '-password' flags are given, only those credentials can be used for authentication

Additional users can be added via the ssoadmin APIs or using govc for example:

  % govc sso.user.create -p password govc

Closes vmware#2852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature lifecycle/frozen
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vcsim: add ssoadmin user and group management dougm/govmomi
2 participants
@dougm @dbuenoparedes