-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detailed error message for execli errors #3072
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @liron-l , change looks good. Can you update the commit message to something like:
govc: add detail error message for host.esxcli commands
Closes #3073
Mainly the govc:
prefix and issue reference, which is used for the generated ChangeLog: https://github.com/vmware/govmomi/blob/main/CONTRIBUTING.md#format-of-the-commit-message
@liron-l, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed. |
5578565
to
e5f3cd0
Compare
@dougm done, can we merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @liron-l !
PR vmware#3072 added fault detail to the error message, breaking existing code at runtime.
PR vmware#3072 added fault detail to the error message, breaking existing code at runtime.
PR vmware#3072 added fault detail to the error message, breaking existing code at runtime.
Description
Include full fault details in error message, otherwise we get
And cannot diagnose the SDK errors
Closes: #3073
Type of change
Please mark options that are relevant:
not work as expected)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. If applicable, please also list any relevant
details for your test configuration.
Verified fix against live environment that returns the error for objects that are not found
Checklist:
CONTRIBUTION
guidelines of
this project