Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detailed error message for execli errors #3072

Merged
merged 1 commit into from
May 11, 2023

Conversation

liron-l
Copy link
Contributor

@liron-l liron-l commented Mar 21, 2023

Description

Include full fault details in error message, otherwise we get

EsxCLI.CLIFault.summary

And cannot diagnose the SDK errors

Closes: #3073

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. If applicable, please also list any relevant
details for your test configuration.

  • Test Description 1
    Verified fix against live environment that returns the error for objects that are not found
  • Test Description 2

Checklist:

  • My code follows the CONTRIBUTION
    guidelines of
    this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

@vmwclabot
Copy link
Member

@liron-l, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liron-l , change looks good. Can you update the commit message to something like:

govc: add detail error message for host.esxcli commands

Closes #3073

Mainly the govc: prefix and issue reference, which is used for the generated ChangeLog: https://github.com/vmware/govmomi/blob/main/CONTRIBUTING.md#format-of-the-commit-message

@vmwclabot
Copy link
Member

@liron-l, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@liron-l
Copy link
Contributor Author

liron-l commented May 11, 2023

@dougm done, can we merge?

Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liron-l !

@dougm dougm merged commit 99cea86 into vmware:main May 11, 2023
@vmwclabot
Copy link
Member

@liron-l, VMware has rejected your signed contributor license agreement. The change has already been merged, but it will be backed out by the project maintainers if the agreement is not resigned in a timely manner. Click here to resign the agreement.

dougm added a commit to dougm/govmomi that referenced this pull request May 19, 2023
PR vmware#3072 added fault detail to the error message, breaking existing code at runtime.
dougm added a commit to dougm/govmomi that referenced this pull request May 19, 2023
PR vmware#3072 added fault detail to the error message, breaking existing code at runtime.
priyanka19-98 pushed a commit to priyanka19-98/govmomi that referenced this pull request Jan 17, 2024
PR vmware#3072 added fault detail to the error message, breaking existing code at runtime.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Esxcli does not return full error details
3 participants