fix: add esxcli.Fault and revert Error() string #3131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akutz
previously approved these changes
May 19, 2023
There was a problem hiding this comment.
lgtm, thank you! I do wonder if we can look into the ESX sources to find out if there are standard error strings we can then write helper funcs for in this package. I'm thinking something similar to https://pkg.go.dev/k8s.io/apimachinery/pkg/api/errors, where you can do errors.IsNotFound(err) or errors.IsInvalid(err), etc.
akutz
reviewed
May 19, 2023
PR vmware#3072 added fault detail to the error message, breaking existing code at runtime.
akutz
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #3072 added fault detail to the error message, breaking existing code at runtime.