fix: support binary
and dateTime
in JSON
#3128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for
binary
anddateTime
in JSON.For
binary
golang[]byte
JSON serialization matches the vCenter format. Thus adding the name ot the maps was enough.For
dateTime
the format oftime.Time
Marshaler
andUnmarshaler
matches vCenter format. The discriminator code required support for custom marshaling logic. In addition the name had to be mapped.Description
Please include a summary of the change and which issue is fixed. Please also
include relevant motivation and context. List any dependencies that are required
for this change.
Closes: #3127
Type of change
Please mark options that are relevant:
not work as expected)
How Has This Been Tested?
Checklist:
CONTRIBUTION
guidelines of
this project