Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcsim: Fix:#3423 - mandated to pass the new disk size in Bytes and KB… #3424

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

Davinder2me
Copy link

…. If either of value is 0, ReconfigVM_Task is throwing *types.InvalidDeviceOperation

Closes: #3423

Description

Fix the new disk size check.

Closes: #(issue-number)

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. If applicable, please also list any relevant
details for your test configuration.

  • Deployed VM using vRA using vCSIM. And Vm provisioning was successful. ReconfigureVM_task successful.

Checklist:

  • My code follows the CONTRIBUTION guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

@vmwclabot
Copy link
Member

@Davinder2me, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

CapacityInBytes and the deprecated CapacityInKB fields do not both need to be set.

Closes: vmware#3423
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Davinder2me

@dougm dougm merged commit ae5fd92 into vmware:main Apr 24, 2024
10 checks passed
dougm added a commit to dougm/govmomi that referenced this pull request Jun 7, 2024
PR vmware#3424 switched from the deprecated CapacityInKB field to CapacityInBytes.
That PR focus was to fix an issue with the simulator, but broke against real vCenter.
Just leaving CapacityInKB as-is makes vCenter happy again.

Fixes vmware#3464
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants