-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for SA annotations #167
Adds support for SA annotations #167
Conversation
@kkapoor1987, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
1dba5a8
to
a40b344
Compare
@dimalbaby Can you please review this !!! |
8d69f58
to
5d8c783
Compare
@viveksyngh Can you review and help me merge these changes |
@kkapoor1987 could you please rebase and update your branch with master ? |
5d8c783
to
b4cf643
Compare
@viveksyngh thanks for the update... I believe it's ready for review now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kkapoor1987 , thank you for the contribution!
Do we need to update the chart version here?
Just increment here by the minor version for some of users who could be using helm charts servers and helm packaging and versioning the log-router chart:
https://github.com/vmware/kube-fluentd-operator/blob/master/charts/log-router/Chart.yaml#L7
Adds support for fullName override to the chart Solves vmware#160 Signed-off-by: Karan Kapoor <karan.kapoor@pega.com>
b4cf643
to
f21f079
Compare
@Cryptophobia Thanks for that ...I just pushed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Solves #160, #139
Signed-off-by: Karan Kapoor karan.kapoor@pega.com