AV-205821 add external httppolicyset in cache #1435
Conversation
arihantg
requested review from
akshayhavile,
aaha97,
pkoshtavmware,
saurabhvaidvmware and
DixitAakash
|
build ako |
1 similar comment
|
build ako |
| @@ -2006,8 +2062,11 @@ func (c *AviObjCache) AviObjVSCachePopulate(client *clients.AviClient, cloud str | |||
| c.PopulateHttpPolicySetToCache(client, cloud) | |||
There was a problem hiding this comment.
@arihantg: If we look at PopulateHttpPolicySetToCache function, it fetches all httpps which is created by AKO user and populate the cache. And then we retrieve out httpps by uuid at line number 2063. I think fetching all httpps each time is not required here (at line number 2062) as we are going through httpps attached to each VS.
Instead of this call, we can call your function AviPopulateHttpPolicySetbyUUID here. So that it will fetch it from uuid.
All HTTPPS cache update is already happened as part of AviRefreshObjectCache
There was a problem hiding this comment.
I have replaced the 2nd call to PopulateHttpPolicySetToCache with AviPopulateHttpPolicySetbyUUID.
|
build ako |
3 similar comments
|
build ako |
|
build ako |
|
build ako |
|
build ako |
|
build ako |
At bootup AKO was making calls to populate httppolicy set in cache for each VS if it was finding missing match in cache for any external policyset. With this fix we will fetch the missing policyset by uuid and add it to cache.