-
Notifications
You must be signed in to change notification settings - Fork 415
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix NULL pointer dereference and remove three lines of dead code.
QbitLogic has run [Code]Ai on the open-vm-tools source code and and notified VMware of a potential NULL pointer reference and four pieces of dead code. See #247 bora-vmsoft/services/vmtoolsd/pluginMgr.c The proposed fix conditionally emitted a log message. That fix has been reworked to consistently emit a log message with conditional content. bora/lib/misc/posixPosix.c bora-vmsoft/apps/toolbox-cmd/toolboxcmd-shrink.c Remove one line of dead code from each source file. bora-vmsoft/lib/procMgr/procMgrPosix.c: Suggested dead code fix actually pointed to a bug where errno was not getting updated as intended. bora-vmsoft/services/plugins/guestInfo/perfMonLinux.c: Suggested dead code is no longer dead; change not applicable.
- Loading branch information
1 parent
bbcb8a4
commit f91f735
Showing
5 changed files
with
9 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters