CodeAi fixes: 1 Null Deref, and 4 Dead Code #247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Access to field 'name' results in a dereference of a null pointer (loaded from field 'data') Signed-off-by: C0deAi <techsupport@mycode.ai>
Value stored to 'rc' is never read Signed-off-by: C0deAi <techsupport@mycode.ai>
Value stored to 'memNeededReservation' is never read Signed-off-by: C0deAi <techsupport@mycode.ai>
Value stored to 'n' is never read Signed-off-by: C0deAi <techsupport@mycode.ai>
Value stored to 'error' is never read Signed-off-by: C0deAi <techsupport@mycode.ai>
|
@C0deAi, your company's legal contact has approved your signed contributor license agreement. It will also be reviewed by VMware, but the merge can proceed. |
|
@C0deAi, VMware has approved your signed contributor license agreement. |
|
@C0deAi, |
oliverkurth
added a commit
that referenced
this pull request
Dec 18, 2018
QbitLogic has run [Code]Ai on the open-vm-tools source code and and notified VMware of a potential NULL pointer reference and four pieces of dead code. See #247 bora-vmsoft/services/vmtoolsd/pluginMgr.c The proposed fix conditionally emitted a log message. That fix has been reworked to consistently emit a log message with conditional content. bora/lib/misc/posixPosix.c bora-vmsoft/apps/toolbox-cmd/toolboxcmd-shrink.c Remove one line of dead code from each source file. bora-vmsoft/lib/procMgr/procMgrPosix.c: Suggested dead code fix actually pointed to a bug where errno was not getting updated as intended. bora-vmsoft/services/plugins/guestInfo/perfMonLinux.c: Suggested dead code is no longer dead; change not applicable.
oliverkurth
added a commit
that referenced
this pull request
Jan 29, 2019
QbitLogic has run [Code]Ai on the open-vm-tools source code and and notified VMware of a potential NULL pointer reference and four pieces of dead code. See #247 bora-vmsoft/services/vmtoolsd/pluginMgr.c The proposed fix conditionally emitted a log message. That fix has been reworked to consistently emit a log message with conditional content. bora/lib/misc/posixPosix.c bora-vmsoft/apps/toolbox-cmd/toolboxcmd-shrink.c Remove one line of dead code from each source file. bora-vmsoft/lib/procMgr/procMgrPosix.c: Suggested dead code fix actually pointed to a bug where errno was not getting updated as intended. bora-vmsoft/services/plugins/guestInfo/perfMonLinux.c: Suggested dead code is no longer dead; change not applicable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeAI (www.mycode.ai) found 166 defects and fixed 40 in open-vm-tools. It wants to merge commits fixing 5 of these issues- 1 Null Pointer Dereference, and 4 Dead Code. A screenshot of the results as well as the Dockerfile used to build and run your project in CodeAI can be found here.