reactor: transition to Publish-PasswordHealth
#111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenthirtyam
added
enhancement
- Updates `Publish-PasswordHealth` to return the results from the SoS Health Summary JSON data. #90 - Updates `Invoke-VcfHealthReport` to use the `Publish-PasswordHealth` cmdlet. #90 - Updates `Publish-PasswordHealth` to include an "Expires In (Days)" column. #40 - Removes `Publish-LocalUserExpiry` in favor of the `Publish-PasswordHealth` cmdlet. #90 - Bumps the module version to v2.0.0.1004. - Updates `CHANGELOG.md`. Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam
force-pushed
the
reactor/password-health
branch
from
3a97750
to
e65b293
Compare
tenthirtyam
commented
Apr 3, 2023
tenthirtyam
added a commit
that referenced
this pull request
Apr 12, 2023
- Removes `Request-SddcManagerUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-vCenterUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-NsxtManagerUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-NsxtEdgeUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-Request-vRslcmUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Updates `CHANGELOG.md`. Ref: #111 Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
11 tasks
tenthirtyam
added a commit
that referenced
this pull request
Apr 12, 2023
- Removes `Request-SddcManagerUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-vCenterUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-NsxtManagerUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-NsxtEdgeUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-Request-vRslcmUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Updates `CHANGELOG.md`. Ref: #111 Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam
added a commit
that referenced
this pull request
Apr 12, 2023
- Removes `Request-SddcManagerUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-vCenterUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-NsxtManagerUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-NsxtEdgeUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-Request-vRslcmUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Updates `CHANGELOG.md`. Ref: #111 Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
4 tasks
tenthirtyam
added a commit
that referenced
this pull request
Apr 12, 2023
- Removes `Request-SddcManagerUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-vCenterUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-NsxtManagerUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-NsxtEdgeUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-Request-vRslcmUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Updates `CHANGELOG.md`. Ref: #111 Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam
added a commit
that referenced
this pull request
Apr 12, 2023
- Removed `Request-LocalUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-SddcManagerUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-vCenterUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-NsxtManagerUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-NsxtEdgeUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-Request-vRslcmUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Updates `CHANGELOG.md`. Ref: #111 Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam
added a commit
that referenced
this pull request
Apr 12, 2023
- Removed `Request-LocalUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-SddcManagerUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-vCenterUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-NsxtManagerUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-NsxtEdgeUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-Request-vRslcmUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Updates incorrect parameter names in examples and descriptions. - Updates `CHANGELOG.md`. Ref: #111 Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam
added a commit
that referenced
this pull request
Apr 12, 2023
- Removed `Request-LocalUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-SddcManagerUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-vCenterUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-NsxtManagerUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-NsxtEdgeUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-Request-vRslcmUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Updates incorrect parameter names in examples and descriptions. - Updates `CHANGELOG.md`. Ref: #111 Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam
added a commit
that referenced
this pull request
Apr 13, 2023
- Removed `Request-LocalUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-SddcManagerUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-vCenterUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-NsxtManagerUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-NsxtEdgeUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-Request-vRslcmUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Updates incorrect parameter names in examples and descriptions. - Updates `CHANGELOG.md`. Ref: #111 Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam
added a commit
that referenced
this pull request
Apr 13, 2023
- Removed `Request-LocalUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-SddcManagerUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-vCenterUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-NsxtManagerUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-NsxtEdgeUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Removes `Request-Request-vRslcmUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet. - Updates incorrect parameter names in examples and descriptions. - Updates `CHANGELOG.md`. Ref: #111 Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.
Summary of Pull Request
Publish-PasswordHealthto return the results from the SoS Health Summary JSON data. Transition toPublish-PasswordHealthfromPublish-LocalUserExpiry#90Invoke-VcfHealthReportto use thePublish-PasswordHealthcmdlet. Transition toPublish-PasswordHealthfromPublish-LocalUserExpiry#90Publish-PasswordHealthto include an "Expires In (Days)" column. Add support to display "Expires In (Days)" in the Password section of the Health Report #40Publish-LocalUserExpiryin favor of thePublish-PasswordHealthcmdlet. Transition toPublish-PasswordHealthfromPublish-LocalUserExpiry#90CHANGELOG.md.Type of Pull Request
Please describe:
Related to Existing Issues
Closes #90
Closes #40
Closes #39
Test and Documentation Coverage
Breaking Changes?