Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove Publish-LocalUserExpiry support functions #120

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

tenthirtyam
Copy link
Contributor

@tenthirtyam tenthirtyam commented Apr 12, 2023

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

  • Removes Request-LocalUserExpiry which supported the Publish-LocalUserExpiry cmdlet.
  • Removes Request-SddcManagerUserExpiry which supported the Publish-LocalUserExpiry cmdlet.
  • Removes Request-vCenterUserExpiry which supported the Publish-LocalUserExpiry cmdlet.
  • Removes Request-NsxtManagerUserExpiry which supported the Publish-LocalUserExpiry cmdlet.
  • Removes Request-NsxtEdgeUserExpiry which supported the Publish-LocalUserExpiry cmdlet.
  • Removes Request-Request-vRslcmUserExpiry which supported the Publish-LocalUserExpiry cmdlet.
  • Updates CHANGELOG.md.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Ref: #111

Closes #89

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam tenthirtyam added the refactor Refactor label Apr 12, 2023
@tenthirtyam tenthirtyam added this to the v2.0.0 milestone Apr 12, 2023
@tenthirtyam tenthirtyam self-assigned this Apr 12, 2023
@tenthirtyam tenthirtyam force-pushed the refactor/remove-local-user-exipry-helpers branch 2 times, most recently from a8eb2d3 to 28ed79b Compare April 12, 2023 18:10
@tenthirtyam tenthirtyam marked this pull request as ready for review April 12, 2023 18:23
@tenthirtyam tenthirtyam requested a review from a team as a code owner April 12, 2023 18:23
@tenthirtyam tenthirtyam marked this pull request as draft April 12, 2023 18:30
@tenthirtyam tenthirtyam force-pushed the refactor/remove-local-user-exipry-helpers branch 4 times, most recently from 6faa568 to 4544547 Compare April 12, 2023 19:27
@tenthirtyam tenthirtyam marked this pull request as ready for review April 12, 2023 19:45
GaryJBlake
GaryJBlake previously approved these changes Apr 13, 2023
Copy link
Contributor

@GaryJBlake GaryJBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CHANGELOG.md Outdated Show resolved Hide resolved
- Removed `Request-LocalUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet.
- Removes `Request-SddcManagerUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet.
- Removes `Request-vCenterUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet.
- Removes `Request-NsxtManagerUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet.
- Removes `Request-NsxtEdgeUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet.
- Removes `Request-Request-vRslcmUserExpiry` which supported the `Publish-LocalUserExpiry` cmdlet.
- Updates incorrect parameter names in examples and descriptions.
- Updates `CHANGELOG.md`.

Ref: #111

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
Copy link
Contributor

@GaryJBlake GaryJBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tenthirtyam tenthirtyam merged commit c4e9ef6 into main Apr 13, 2023
@tenthirtyam tenthirtyam deleted the refactor/remove-local-user-exipry-helpers branch April 13, 2023 12:59
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
refactor Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Technical debt for consistent naming across cmdlet parameters
2 participants