Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add secure strings for sensitive parameters #199

Conversation

Ashwini-Ravi
Copy link
Contributor

@Ashwini-Ravi Ashwini-Ravi commented Dec 15, 2023

Summary

Added support for use of secure strings for sensitive parameters.

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Closes #195

Additional Information

@Ashwini-Ravi Ashwini-Ravi requested a review from a team as a code owner December 15, 2023 06:53
@vmwclabot vmwclabot added the dco-required DCO Required label Dec 15, 2023
@tenthirtyam tenthirtyam force-pushed the feat-add-secure-strings-for-sensitive-parameters branch from a84ee09 to 7a3b538 Compare December 15, 2023 12:53
@vmwclabot vmwclabot removed the dco-required DCO Required label Dec 15, 2023
@tenthirtyam tenthirtyam force-pushed the feat-add-secure-strings-for-sensitive-parameters branch from 7a3b538 to cd7e348 Compare December 15, 2023 12:55
@tenthirtyam tenthirtyam changed the title feat: password encryption feature implemented feat: add secure strings for sensitive parameters Dec 15, 2023
@vmware vmware deleted a comment from vmwclabot Dec 15, 2023
@vmware vmware deleted a comment from vmwclabot Dec 15, 2023
@tenthirtyam tenthirtyam added the enhancement Enhancement label Dec 15, 2023
@tenthirtyam tenthirtyam added this to the v2.5.0 milestone Dec 15, 2023
@tenthirtyam tenthirtyam force-pushed the feat-add-secure-strings-for-sensitive-parameters branch 2 times, most recently from af7c1dd to b3b0313 Compare December 15, 2023 21:34
@github-actions github-actions bot added documentation Documentation needs-review Needs Review labels Dec 15, 2023
Added support for use of secure strings for sensitive parameters.

Ref: vmware#195

Signed-off-by: Ashwini Ravindernath <ashwini.ravindernath@broadcom.com>
@tenthirtyam tenthirtyam force-pushed the feat-add-secure-strings-for-sensitive-parameters branch from b3b0313 to e17f51f Compare December 15, 2023 21:37
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and LGTM! Thanks for pulling this in, @Ashwini-Ravi . 🚀

I force-pushed a change in b3b0313 to add back a small section of examples that were removed and to correct some minor formatting.

@tenthirtyam tenthirtyam merged commit 2e04387 into vmware:develop Dec 15, 2023
1 check passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for use of secure strings for sensitive parameters
3 participants