Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: report output failing #217

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

GaryJBlake
Copy link
Contributor

@GaryJBlake GaryJBlake commented May 22, 2024

Summary

  • Updated Invoke-VcfHealthReport cmdlet to handle . or - in the report path.
  • Updated Invoke-VcfAlertReport cmdlet to handle . or - in the report path.
  • Updated Invoke-VcfConfigReport cmdlet to handle . or - in the report path.
  • Updated Invoke-VcfUpgradePrecheck cmdlet to handle . or - in the report path.
  • Updated Invoke-VcfOverviewReport cmdlet to handle . or - in the report path.

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Closes #216

Additional Information

- Updated `Invoke-VcfHealthReport` cmdlet to handle . or - in the report path.
- Updated `Invoke-VcfAlertReport` cmdlet to handle . or - in the report path.
- Updated `Invoke-VcfConfigReport` cmdlet to handle . or - in the report path.
- Updated `Invoke-VcfUpgradePrecheck` cmdlet to handle . or - in the report path.
- Updated `Invoke-VcfOverviewReport` cmdlet to handle . or - in the report path.

Signed-off-by: Gary Blake <gblake@vmware.com>
@GaryJBlake GaryJBlake added the bug Bug label May 22, 2024
@GaryJBlake GaryJBlake added this to the v2.6.2 milestone May 22, 2024
@GaryJBlake GaryJBlake self-assigned this May 22, 2024
@GaryJBlake GaryJBlake requested a review from a team as a code owner May 22, 2024 10:41
@github-actions github-actions bot added documentation Documentation needs-review Needs Review labels May 22, 2024
@tenthirtyam tenthirtyam merged commit f0bf494 into develop May 22, 2024
5 checks passed
@tenthirtyam tenthirtyam deleted the fix-report-output-failing branch May 22, 2024 11:53
tenthirtyam pushed a commit that referenced this pull request May 23, 2024
Updated `Invoke-*Report` cmdlets to handle `.` or `-` in the report path.
tenthirtyam pushed a commit that referenced this pull request May 23, 2024
Updated `Invoke-*Report` cmdlets to handle `.` or `-` in the report path.
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug documentation Documentation needs-review Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reportpath for VCF Reports is changed due to some characters in Path
2 participants