Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update Publish-* methods for JSON generation #79

Merged

Conversation

bhumitra
Copy link
Contributor

@bhumitra bhumitra commented Jan 25, 2023

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

Updated Publish-* cmdlets to support JSON generation for:

  • Publish-BackupStatus
  • Publish-NsxtTransportNodeStatus
  • Publish-NsxtTier0BgpStatus
  • Publish-SnapshotStatus
  • Publish-LocalUserExpiry
  • Publish-StorageCapacityHealth

Added 2 additional functions:

  • Publish-NsxtHealthNonSOS
  • Publish-ComponentConnectivityHealthNonSOS

Signed-off-by: bhumitra nagar bnagar@vmware.com

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Closes #37

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

New if/else path has been added to these cmdlets. if called using -jsonOutput, then JSON is generated. Else, the functionality is the same as before. I have tested the functionality and it works fine.

Signed-off-by: bhumitra nagar <bnagar@vmware.com>
@bhumitra bhumitra requested a review from a team as a code owner January 25, 2023 18:18
@github-actions github-actions bot added the needs-review Needs Review label Jan 25, 2023
@tenthirtyam tenthirtyam changed the title Feat: Update Publish-* methods for JSON generation feat: update Publish-* methods for JSON generation Jan 25, 2023
@tenthirtyam tenthirtyam added this to the v1.1.0 milestone Jan 25, 2023
@tenthirtyam tenthirtyam added the feature Feature label Jan 25, 2023
@tenthirtyam
Copy link
Contributor

Hi @bhumitra -

I’ve marked the pull request for the v1.1.0 milestone release planned for February 2023. We will hold the merging of this pull request until after the v1.0.6 milestone release for January 2023. Reviews will, however, occur soon. 🚀

Ryan Johnson
Senior Staff Solutions Architect | Product Engineering @ VMware, Inc.

@tenthirtyam tenthirtyam added the size/m Relative Sizing: medium label Jan 30, 2023
@tenthirtyam
Copy link
Contributor

Update: I will review it soon now that v1.0.6 is now released.

Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requestion on first pass:

  • Other examples and the README.md use F:\Reporting vs F:\Reports. Added suggestions to keep them consistent.
  • Use -Depth vs -depth.
  • Minor grammatical suggestions.

VMware.CloudFoundation.Reporting.psm1 Outdated Show resolved Hide resolved
VMware.CloudFoundation.Reporting.psm1 Outdated Show resolved Hide resolved
VMware.CloudFoundation.Reporting.psm1 Outdated Show resolved Hide resolved
VMware.CloudFoundation.Reporting.psm1 Outdated Show resolved Hide resolved
VMware.CloudFoundation.Reporting.psm1 Outdated Show resolved Hide resolved
VMware.CloudFoundation.Reporting.psm1 Outdated Show resolved Hide resolved
VMware.CloudFoundation.Reporting.psm1 Outdated Show resolved Hide resolved
VMware.CloudFoundation.Reporting.psm1 Outdated Show resolved Hide resolved
VMware.CloudFoundation.Reporting.psm1 Outdated Show resolved Hide resolved
VMware.CloudFoundation.Reporting.psm1 Outdated Show resolved Hide resolved
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Jan 31, 2023
Signed-off-by: bhumitra nagar <bnagar@vmware.com>

Co-authored-by: Ryan Johnson <ryan@tenthirtyam.org>
@tenthirtyam
Copy link
Contributor

Thanks for committing the review suggestions.

I’ll give in a flurry of tests tomorrow and report back.

@tenthirtyam tenthirtyam self-requested a review February 2, 2023 21:21
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@vmwclabot vmwclabot added the dco-required DCO Required label Feb 3, 2023
Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
@tenthirtyam tenthirtyam force-pushed the feat-JSON-generation-for-Publish-methods branch from 2bf47c9 to 0d62d83 Compare February 3, 2023 21:23
@vmwclabot vmwclabot removed the dco-required DCO Required label Feb 3, 2023
@vmware vmware deleted a comment from vmwclabot Feb 3, 2023
@tenthirtyam tenthirtyam merged commit a39112b into vmware:main Feb 3, 2023
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2023
@bhumitra bhumitra deleted the feat-JSON-generation-for-Publish-methods branch March 17, 2023 19:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Feature size/m Relative Sizing: medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for JSON output to each Publish-* cmdlet
3 participants