-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support realized_id in ip pool data source #1008
Conversation
/test-all |
|
It is just more convenient.. we expose this attribute in resource, makes sense to do this in data source as well |
But policy_ip_pool resource doesn't have this attribute. |
It's always good to be consistent indeed. Also, as the attribute in API spec is called realization_id, I would stay consistent also with naming |
We already have |
67bc6ab
to
2e1feec
Compare
I've added this attribute to the resource as well |
/test-all |
1 similar comment
/test-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please rebase on top of master so tests will pass.
I think that maybe in a couple of more we can justify a getRealizedIdSchema()
func :)
This id should be used in transport node resource Signed-off-by: Anna Khmelnitsky <akhmelnitsky@vmware.com>
2e1feec
to
05103db
Compare
/test-all |
This id should be used in transport node resource
Signed-off-by: Anna Khmelnitsky akhmelnitsky@vmware.com