Initial IPAM support #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a copy/paste bug in some unittests which caused the destruction tests to be skipped.
Fixing some compilation & fmt error in the terragen code (which automatically generates the resource code & documentation for new resources) Also adding the code for import support to terragen
Adding support for ip_pool and ip_block resources
annakhm
reviewed
Apr 24, 2018
nsxt/resource_nsxt_ip_block.go
Outdated
| "net/http" | ||
| ) | ||
|
|
||
| // formatLogicalRouterRollbackError defines the verbose error when |
nsxt/resource_nsxt_ip_block.go
Outdated
| old_subnets := old_data.([]interface{}) | ||
| new_subnets := new_data.([]interface{}) | ||
| // Go over the new subnets and check which should be created new and which was modified | ||
| log.Printf("[DEBUG] DEBUG ADIT subnets changed?\n old %#v\n new %#v", old_subnets, new_subnets) |
There was a problem hiding this comment.
lets remove this (and below)
nsxt/resource_nsxt_ip_block.go
Outdated
| Optional: true, | ||
| Elem: &schema.Resource{ | ||
| Schema: map[string]*schema.Schema{ | ||
| "id": &schema.Schema{ |
There was a problem hiding this comment.
I think we need to understand where these ids are used.. if other resources could be dependent on these, maybe it would be preferable to expose these as separate objects?
Sync vendor with the new sdk code
Update terragen
Fix destruction test in unittests
Adding support for ip_pool and ip_block resources
Closed
annakhm
approved these changes
May 1, 2018
| return fmt.Errorf("Unexpected status returned during IpBlockSubnet create: %v", resp.StatusCode) | ||
| } | ||
| d.SetId(ipBlockSubnet.Id) | ||
|
|
There was a problem hiding this comment.
I wonder if d.Set("block_id", blockId) here might work around the nsx bug (won't work for read though, not sure how bad this is)
There was a problem hiding this comment.
Since the read is always called after create/update I don't think it will help. But anyway we will not fully support IPAM in this NSX version, and it will be fixed for the next one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for ip_pool and ip_block resources