Add dns_servers option to vcd_nsxt_network_dhcp resource #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeletux
requested review from
lvirbalas,
dataclouder,
Didainius,
vbauzys and
adambarreiro
as code owners
lvirbalas
approved these changes
Apr 21, 2022
lvirbalas
reviewed
Apr 21, 2022
Didainius
reviewed
Apr 21, 2022
vbauzys
approved these changes
Apr 25, 2022
added 9 commits
April 27, 2022 10:48
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
added 2 commits
April 27, 2022 10:48
Signed-off-by: Miguel Sama <msama@vmware.com>
mikeletux
force-pushed
the
feature-nsxt-dhcp-dns
branch
from
741eed5
to
488c2a2
Compare
Signed-off-by: Miguel Sama <msama@vmware.com>
Didainius
approved these changes
Apr 28, 2022
Signed-off-by: Miguel Sama <msama@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relays on vmware/go-vcloud-director#465
Description
On issue #753 it is suggested to implement DNS servers to
vcd_nsxt_network_dhcp, as it is available from VCD 10.3.1.Detailed description
This PR introduces the possibility of adding
dns_serversto thevcd_nsxt_network_dhcpresource.Since
dns_serversis a feature introduced on VCD 10.3.1 (API v36.1), if these are set and the VCD version the user is working on is below that, it will error.Successfully tested on VCD 10.3.2 with system administrator as well as org administrator