Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vApp Template support for vcd_vapp_vm and vcd_vm resource and data sources #931

Merged
merged 59 commits into from
Nov 18, 2022

Conversation

adambarreiro
Copy link
Collaborator

@adambarreiro adambarreiro commented Nov 15, 2022

Description

This PR:

The proposed changes add the following attributes to vcd_vapp_vm and vcd_vm resource and data source:

  • vapp_template_id: The URN of the vApp Template to use. Deprecates template_name. The idea is to use the newest vcd_catalog_vapp_template data source to fetch this unique URN.
  • boot_image_id: The URN of the media to use as boot image. Deprecates boot_image. The idea is to use vcd_catalog_media datasource to fetch this unique URN.

As the URNs are unique, the need of catalog_name is no more, so it has been deprecated as well.

This PR deprecates vcd_catalog_item as well.

Not included

This PR doesn't change resource vcd_inserted_media, which will remain in backlog as it requires to use IDs instead of names.

Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
#
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
…ider-vcd into add-placement-policy-to-vm

Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
…ider-vcd into add-placement-policy-to-vm

Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro marked this pull request as ready for review November 16, 2022 16:26
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is important change. Let's write it up in a blog post too, @adambarreiro

@adambarreiro adambarreiro merged commit 04a783a into vmware:main Nov 18, 2022
@janbaer
Copy link

janbaer commented Jul 6, 2023

How can I migrate my TF state to the new version without destroying and recreating all of my VMs? This breaking change is really dangerous.

@adambarreiro
Copy link
Collaborator Author

How can I migrate my TF state to the new version without destroying and recreating all of my VMs? This breaking change is really dangerous.

Thanks for your feedback. I'd say that in this case (existing VMs) it's better to stay with current template_name attribute, while using vapp_template_id for the new ones. The template_name didn't change its behavior and still works, the Deprecated warning is more of a heads up to switch to vapp_template_id whenever possible.
We will try to find a proper solution for this scenario that guarantees that VMs don't get recreated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants