-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vApp Template support for vcd_vapp_vm and vcd_vm resource and data sources #931
Add vApp Template support for vcd_vapp_vm and vcd_vm resource and data sources #931
Conversation
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
…ider-vcd into add-placement-policy-to-vm Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
…ider-vcd into add-placement-policy-to-vm Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is important change. Let's write it up in a blog post too, @adambarreiro
How can I migrate my TF state to the new version without destroying and recreating all of my VMs? This breaking change is really dangerous. |
Thanks for your feedback. I'd say that in this case (existing VMs) it's better to stay with current |
Description
This PR:
The proposed changes add the following attributes to vcd_vapp_vm and vcd_vm resource and data source:
vapp_template_id
: The URN of the vApp Template to use. Deprecatestemplate_name
. The idea is to use the newestvcd_catalog_vapp_template
data source to fetch this unique URN.boot_image_id
: The URN of the media to use as boot image. Deprecatesboot_image
. The idea is to usevcd_catalog_media
datasource to fetch this unique URN.As the URNs are unique, the need of
catalog_name
is no more, so it has been deprecated as well.This PR deprecates vcd_catalog_item as well.
Not included
This PR doesn't change resource
vcd_inserted_media
, which will remain in backlog as it requires to use IDs instead of names.