Skip to content

Commit

Permalink
control-service: fix job builder unit tests (#792)
Browse files Browse the repository at this point in the history
The unit tests have been failed due to the wrong expected type. They
expect String but the value is NULL.

Testing done: unit tests

Signed-off-by: Miroslav Ivanov miroslavi@vmware.com
  • Loading branch information
mivanov1988 committed Apr 7, 2022
1 parent 65203b3 commit b10d6f5
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public void buildImage_notExist_success() throws InterruptedException, ApiExcept

verify(kubernetesService).createJob(
eq(TEST_BUILDER_JOB_NAME), eq(TEST_BUILDER_IMAGE_NAME), eq(false), any(), any(),
any(), any(), any(), any(), any(), anyLong(), anyLong(), anyLong(), anyString());
any(), any(), any(), any(), any(), anyLong(), anyLong(), anyLong(), any());

verify(kubernetesService).deleteJob(TEST_BUILDER_JOB_NAME);
Assertions.assertTrue(result);
Expand All @@ -114,7 +114,7 @@ public void buildImage_builderRunning_oldBuilderDeleted() throws InterruptedExce
verify(kubernetesService, times(2)).deleteJob(TEST_BUILDER_IMAGE_NAME);
verify(kubernetesService).createJob(
eq(TEST_BUILDER_JOB_NAME), eq(TEST_BUILDER_IMAGE_NAME), eq(false), any(), any(),
any(), any(), any(), any(), any(), anyLong(), anyLong(), anyLong(), anyString());
any(), any(), any(), any(), any(), anyLong(), anyLong(), anyLong(), any());
Assertions.assertTrue(result);
}

Expand Down Expand Up @@ -156,7 +156,7 @@ public void buildImage_jobFailed_failure() throws InterruptedException, ApiExcep

verify(kubernetesService).createJob(
eq(TEST_BUILDER_JOB_NAME), eq(TEST_BUILDER_IMAGE_NAME), eq(false), any(), any(),
any(), any(), any(), any(), any(), anyLong(), anyLong(), anyLong(), anyString());
any(), any(), any(), any(), any(), anyLong(), anyLong(), anyLong(), any());


// verify(kubernetesService).deleteJob(TEST_BUILDER_JOB_NAME); // not called in case of an error
Expand Down

0 comments on commit b10d6f5

Please sign in to comment.