Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TimeBoxed]Support Python 3.10 #390

Closed
mnozhchev opened this issue Oct 14, 2021 · 1 comment
Closed

[TimeBoxed]Support Python 3.10 #390

mnozhchev opened this issue Oct 14, 2021 · 1 comment
Labels
area/vdk-control-cli area/vdk-core enhancement New feature or request

Comments

@mnozhchev
Copy link

What is the feature request? What problem does it solve?
pip install quickstart-vdk fails on Python 3.10 with a very uninformative message. Also README.md says that vdk requires "Python 3.7+" which implies that Python 3.10 is supported.

Suggested solution
Test vdk on Python 3.10 and, then, update the setup.cfg metadata to include 3.10.

Additional context
image (1)
@mnozhchev mnozhchev added the enhancement New feature or request label Oct 14, 2021
@antoniivanov
Copy link
Collaborator

antoniivanov commented Oct 21, 2021 •
edited

There are 3 components that need to be changed. We may split it into 3 sub-issues when starting to work on that.

vdk-core:

Test vdk on Python 3.10:
Add Gitlab CI Job (similar to the other ones for 3.7-3.9) vdk-core-simple_func_test_with_py310 and vdk-core-build_with_py310 (to vdk-core file -https://github.com/vmware/versatile-data-kit/blob/main/projects/vdk-core/.gitlab-ci.yml)
and if PR passes that's enough

vdk plugins:

The same as vdk-core goes for each plugin. This means editing each plugin CI file: For example https://github.com/vmware/versatile-data-kit/blob/main/projects/vdk-core/plugins/vdk-postgres/.plugin-ci.yml

vdk-control-cli:
Similarly new CI job "vdk-control-cli-build-with-py310" :
https://github.com/vmware/versatile-data-kit/blob/main/projects/vdk-control-cli/.gitlab-ci.yml

I don't anticipate anything to break. But you never know.

@exalate-issue-sync exalate-issue-sync bot changed the title Support Python 3.10 [TimeBoxed]Support Python 3.10 Nov 17, 2021
This was referenced Nov 19, 2021
Merged
Merged
Merged
gageorgiev added a commit that referenced this issue Nov 22, 2021
@gageorgiev
vdk-core: Support Python 3.10 (#528)
6245ce0 
This change makes it so vdk-core supports Python 3.10.
Addresses #390

Signed-off-by: gageorgiev gageorgiev@vmware.com
gageorgiev added a commit that referenced this issue Nov 23, 2021
@gageorgiev @antoniivanov
vdk-core plugins: Support 3.10 (#538)
a2ee065 
* vdk-core plugins: Support 3.10

This change enables support for Python 3.10 for all vdk-core
plugins except for vdk-snowflake since it's connector hasn't
been updated yet.
Addresses #390

Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>

Co-authored-by: Antoni Ivanov <aivanov@vmware.com>
ivakoleva pushed a commit that referenced this issue Nov 29, 2021
@gageorgiev @antoniivanov @ivakoleva
vdk-core plugins: Support 3.10 (#538)
8a05bb9 
* vdk-core plugins: Support 3.10

This change enables support for Python 3.10 for all vdk-core
plugins except for vdk-snowflake since it's connector hasn't
been updated yet.
Addresses #390

Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>

Co-authored-by: Antoni Ivanov <aivanov@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/vdk-control-cli area/vdk-core enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antoniivanov @mnozhchev