control-service: compute the image tag within the script

[murphp15]

Why

I am seeing an issue where helm charts are being released and they point to a pipelines-control-service image that doesn't exist because they have dropped some numbers from the git hash id.
The bug can be seen here: https://gitlab.com/vmware-analytics/versatile-data-kit/-/jobs/3408315682
the image it creates doesn’t have the full commit id.
if you search for image.tag= in the logs you can see that it set the commit to something shorter than the commit id
I also think that adding the quotes when declaring the variable might fix this: #1252
I did test locally but am not able to reproduce either issue locally and I think it is related to the shell version they are using on gitlab.

What

Compute the tag within the script

Signed-off-by: murphp15 murphp15@tcd.ie

[antoniivanov]

What makes you think it's a shell issue?
Shell being so mature and stable seems unlikely to have such a strange behavior even across versions, not for something so basic. Though it happens.
...

I think the bug may be in the helm pack plugin

We use helm pack plugin because helm package doesn't support passing values (like image.tag) - helm/helm#3141

But looking at the helm pack code -https://github.com/thynquest/helm-pack/blob/master/cmd/helmpack/pack.go
It's possible that type inference is lost when passing the arguments.