control-service: java 17 #1439
Merged
control-service: java 17 #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
|
Great, thanks for dealing with this! |
mivanov1988
reviewed
Jan 25, 2023
mivanov1988
reviewed
Jan 25, 2023
...rvice/src/integration-test/java/com/vmware/taurus/graphql/it/GraphQLExecutionsLogsUrlIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: murphp15 <murphp15@tcd.ie>
mivanov1988
approved these changes
Jan 25, 2023
antoniivanov
approved these changes
Jan 25, 2023
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
murphp15
commented
Jan 25, 2023
ivakoleva
approved these changes
Jan 25, 2023
| * java .now() gives nano-second precision and it causes tests written before we adopted that java | ||
| * version to fail. | ||
| */ | ||
| public static OffsetDateTime getTimeAccurateToMicroSecond() { |
There was a problem hiding this comment.
I find the documentation great. My only concern is with duplicated methods
with JobExecutionUtil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Java 17 is more secure and needed for a lot of modern libraries.
More details can be seen here: #1440
What
When using java 17
time.now()returns nanosecond accuracy.This causes problems for us because we only store micro second accuracy in the database.
To overcome this for a lot of tests we use timestamps which are accurate to micro seconds only.
How has this been tested?
Unit and integration tests
closes: #1440
Signed-off-by: murphp15 murphp15@tcd.ie