frontend: open source shared components package #1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we be re-generating package-lock.json? I did it because there were lots of packages pointing to http://build-artifactory.eng.vmware.com. |
DeltaMichael
force-pushed
the
person/mdilyan/os-shared-components
branch
3 times, most recently
from
f220955
to
195b4c3
Compare
ivakoleva
reviewed
Feb 13, 2023
projects/frontend/shared-components/gui/projects/documentation-ui/.browserslistrc
Show resolved
Hide resolved
ivakoleva
reviewed
Feb 13, 2023
...ects/frontend/shared-components/gui/projects/shared/src/lib/common/predicate/simple/index.ts
Show resolved
Hide resolved
projects/frontend/shared-components/gui/projects/shared/src/lib/commons/css/utils.scss
Show resolved
Hide resolved
projects/frontend/shared-components/gui/sonar-project.properties
Outdated
Show resolved
Hide resolved
yes, it's re-generated via build from scratch right |
Yeah, it's generated on first build if it doesn't exist. However, we're committing it to the repo. Instructions in the README.md also state that we have to run Not adding package-lock.json to version control and using the latest dependencies on every build is a little bit controversial, so most projects add it. I was afraid there would be some version conflict when I regenerated it, but everything seems to work fine. |
ivakoleva
reviewed
Feb 13, 2023
projects/frontend/shared-components/gui/projects/shared/package.json
Outdated
Show resolved
Hide resolved
DeltaMichael
changed the title
DeltaMichael
changed the title
DeltaMichael
force-pushed
the
person/mdilyan/os-shared-components
branch
from
9f972ae
to
2497ede
Compare
|
.pre-commit-config.yaml |
ivakoleva
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
I am considering setting the @vdk artifacts version to 1, in the scope of the CI/CD prep 😊
I've fetched this PR changes locally, then tested with a (yet local) branch of frontend/data-pipelines/* I am now wrapping up for code review.
(I can confirm the shared library is operational.)
ivakoleva
reviewed
Feb 13, 2023
projects/frontend/shared-components/gui/projects/documentation-ui/karma.conf.js
Show resolved
Hide resolved
DeltaMichael
force-pushed
the
person/mdilyan/os-shared-components
branch
from
2497ede
to
5130d1c
Compare
ivakoleva
changed the title
sabadzhiev
reviewed
Feb 15, 2023
...tend/shared-components/gui/projects/shared/src/lib/common/interfaces/comparable.interface.ts
Outdated
Show resolved
Hide resolved
...red/src/lib/commons/ngx-components/copy-to-clipboard-button/copy-to-clipboard-button.l10n.ts
Show resolved
Hide resolved
...rontend/shared-components/gui/projects/shared/src/lib/commons/ngx-components/search/index.ts
Outdated
Show resolved
Hide resolved
...omponents/gui/projects/shared/src/lib/commons/ngx-components/search/search.component.spec.ts
Outdated
Show resolved
Hide resolved
...red-components/gui/projects/shared/src/lib/commons/ngx-components/search/search.component.ts
Outdated
Show resolved
Hide resolved
...hared-components/gui/projects/shared/src/lib/commons/ngx-components/toast/toast.component.ts
Outdated
Show resolved
Hide resolved
...d-components/gui/projects/shared/src/lib/commons/ngx-utils/simple-translate-service/index.ts
Show resolved
Hide resolved
sabadzhiev
reviewed
Feb 15, 2023
...shared-components/gui/projects/shared/src/lib/core/navigation/services/navigation.service.ts
Outdated
Show resolved
Hide resolved
DeltaMichael
force-pushed
the
person/mdilyan/os-shared-components
branch
3 times, most recently
from
1d86a83
to
599017b
Compare
|
Please link the tickets created to this PR |
DeltaMichael
force-pushed
the
person/mdilyan/os-shared-components
branch
from
d7cb9d6
to
c977c18
Compare
DeltaMichael
force-pushed
the
person/mdilyan/os-shared-components
branch
from
c977c18
to
95c4800
Compare
https://jira.eng.vmware.com/browse/TAUR-5878 What - replace references to taurus, supercollider, vmw, vmware and tms with vdk - change license to Apache-2.0 - upade copyright headers to reflect license change - regenerate package-lock.json - remove e2e tests - change package versions to 0.0.1 - update zone.js version to fix broken async test - remove author tag from docs How has this been tested Followed instructions to build and test here https://github.com/vmware/versatile-data-kit/blob/person/mdilyan/os-shared-components/projects/frontend/shared-components/gui/README.md https://user-images.githubusercontent.com/91800778/218074170-89ea2cca-1676-47b7-9df2-bad81d2b1ff9.mov What type of change are you making New feature, non-breaking Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
DeltaMichael
force-pushed
the
person/mdilyan/os-shared-components
branch
from
95c4800
to
9b548d7
Compare
This was
unlinked from
issues
Feb 16, 2023
|
Linking the issues will just close them once we merge. I've put them in the description instead. |
sabadzhiev
approved these changes
Feb 16, 2023
ivakoleva
pushed a commit
that referenced
this pull request
Feb 17, 2023
https://jira.eng.vmware.com/browse/TAUR-5878 ### What Open source shared components library - replace references to taurus, supercollider, vmw, vmware and tms with vdk - change license to Apache-2.0 - upade copyright headers to reflect license change - regenerate package-lock.json - remove e2e tests - change package versions to 0.0.1 - update zone.js version to fix broken async test - remove author tag from docs ### How has this been tested Followed instructions to build and test here https://github.com/vmware/versatile-data-kit/blob/person/mdilyan/os-shared-components/projects/frontend/shared-components/gui/README.md https://user-images.githubusercontent.com/91800778/218074170-89ea2cca-1676-47b7-9df2-bad81d2b1ff9.mov ### What type of change are you making New feature, non-breaking ### Follow-up issues #1623 #1641 #1643 #1644 Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
ivakoleva
pushed a commit
that referenced
this pull request
Feb 20, 2023
https://jira.eng.vmware.com/browse/TAUR-5878 ### What Open source shared components library - replace references to taurus, supercollider, vmw, vmware and tms with vdk - change license to Apache-2.0 - upade copyright headers to reflect license change - regenerate package-lock.json - remove e2e tests - change package versions to 0.0.1 - update zone.js version to fix broken async test - remove author tag from docs ### How has this been tested Followed instructions to build and test here https://github.com/vmware/versatile-data-kit/blob/person/mdilyan/os-shared-components/projects/frontend/shared-components/gui/README.md https://user-images.githubusercontent.com/91800778/218074170-89ea2cca-1676-47b7-9df2-bad81d2b1ff9.mov ### What type of change are you making New feature, non-breaking ### Follow-up issues #1623 #1641 #1643 #1644 Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.eng.vmware.com/browse/TAUR-5878
What
Open source shared components library
How has this been tested
Followed instructions to build and test here https://github.com/vmware/versatile-data-kit/blob/person/mdilyan/os-shared-components/projects/frontend/shared-components/gui/README.md
Screen.Recording.2023-02-08.at.19.10.02.mov
What type of change are you making
New feature, non-breaking
Follow-up issues
#1623
#1641
#1643
#1644
Signed-off-by: Dilyan Marinov mdilyan@vmware.com