versatile-data-kit: git pre-commit hooks config #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
Need to be able to prefix commit messages titles with `frontend` component Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
sabadzhiev
reviewed
Feb 14, 2023
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/.eslintrc.js
Outdated
Show resolved
Hide resolved
ivakoleva
force-pushed
the
person/ikoleva/frontend-data-pipelines-precommit
branch
from
0c2daca
to
1f6d3a2
Compare
gageorgiev
approved these changes
Feb 14, 2023
DeltaMichael
approved these changes
Feb 15, 2023
for more information, see https://pre-commit.ci
Frontend config files were failing git pre-coming hooks due: * too large * JSON format inspection * PR title prefix License insertion now covers TypeScript, JavaScript, (S)CSS, HTML, Y(A)ML file types in addition. PR titles can be now associated with "frontend" component. Modified the pre-commit and gitlint configurations accordingly. Testing done: installed the hook locally, and verified all frontend/data-pipelines changes from multiple stacked PRs were committed and auto-modified correctly with the code header expected. Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
for more information, see https://pre-commit.ci
Frontend config files were failing git pre-coming hooks due: * too large * JSON format inspection * PR title prefix License insertion now covers TypeScript, JavaScript, (S)CSS, HTML, Y(A)ML file types in addition. PR titles can be now associated with "frontend" component. Modified the pre-commit and gitlint configurations accordingly. Testing done: installed the hook locally, and verified all frontend/data-pipelines changes from multiple stacked PRs were committed and auto-modified correctly with the code header expected. Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
for more information, see https://pre-commit.ci
Frontend config files were failing git pre-coming hooks due: * too large * JSON format inspection * PR title prefix License insertion now covers TypeScript, JavaScript, (S)CSS, HTML, Y(A)ML file types in addition. PR titles can be now associated with "frontend" component. Modified the pre-commit and gitlint configurations accordingly. Testing done: installed the hook locally, and verified all frontend/data-pipelines changes from multiple stacked PRs were committed and auto-modified correctly with the code header expected. Signed-off-by: ivakoleva <iva.koleva@clearcode.bg>
ivakoleva
deleted the
person/ikoleva/frontend-data-pipelines-precommit
branch
ivakoleva
added a commit
that referenced
this pull request
Feb 15, 2023
Frontend config files were failing git pre-coming hooks due: * too large * JSON format inspection * PR title prefix License insertion now covers TypeScript, JavaScript, (S)CSS, HTML, Y(A)ML file types in addition. PR titles can be now associated with "frontend" component. Modified the pre-commit and gitlint configurations accordingly. Testing done: installed the hook locally, and verified all frontend/data-pipelines changes from multiple stacked PRs were committed and auto-modified correctly with the code header expected. --------- Signed-off-by: ivakoleva <iva.koleva@clearcode.bg> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
ivakoleva
added a commit
that referenced
this pull request
Feb 16, 2023
This is a stacked PR #1 (follows #1625): data-pipelines bundle ceremonies. `data-pipelines/README.md` file path fix in accordance to VEP 1507. Project and artifact bundle configurations added. Version of the cicd-expected ``@vdk/data-pipelines` release is 0.0.1. Proxy configuration set to the cicd-expected control-service instance http://cicd-control-service-svc:8092. Testing done: fetched the `frontend/shared-components` changes (from person/mdilyan/os-shared-components feature branch in review), and verified `frontend/data-pipelines` manual start + unit + e2e tests. --------- Signed-off-by: ivakoleva <iva.koleva@clearcode.bg> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
ivakoleva
added a commit
that referenced
this pull request
Feb 17, 2023
Frontend config files were failing git pre-coming hooks due: * too large * JSON format inspection * PR title prefix License insertion now covers TypeScript, JavaScript, (S)CSS, HTML, Y(A)ML file types in addition. PR titles can be now associated with "frontend" component. Modified the pre-commit and gitlint configurations accordingly. Testing done: installed the hook locally, and verified all frontend/data-pipelines changes from multiple stacked PRs were committed and auto-modified correctly with the code header expected. --------- Signed-off-by: ivakoleva <iva.koleva@clearcode.bg> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
ivakoleva
added a commit
that referenced
this pull request
Feb 17, 2023
This is a stacked PR #1 (follows #1625): data-pipelines bundle ceremonies. `data-pipelines/README.md` file path fix in accordance to VEP 1507. Project and artifact bundle configurations added. Version of the cicd-expected ``@vdk/data-pipelines` release is 0.0.1. Proxy configuration set to the cicd-expected control-service instance http://cicd-control-service-svc:8092. Testing done: fetched the `frontend/shared-components` changes (from person/mdilyan/os-shared-components feature branch in review), and verified `frontend/data-pipelines` manual start + unit + e2e tests. --------- Signed-off-by: ivakoleva <iva.koleva@clearcode.bg> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
ivakoleva
added a commit
that referenced
this pull request
Feb 20, 2023
Frontend config files were failing git pre-coming hooks due: * too large * JSON format inspection * PR title prefix License insertion now covers TypeScript, JavaScript, (S)CSS, HTML, Y(A)ML file types in addition. PR titles can be now associated with "frontend" component. Modified the pre-commit and gitlint configurations accordingly. Testing done: installed the hook locally, and verified all frontend/data-pipelines changes from multiple stacked PRs were committed and auto-modified correctly with the code header expected. --------- Signed-off-by: ivakoleva <iva.koleva@clearcode.bg> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
ivakoleva
added a commit
that referenced
this pull request
Feb 20, 2023
This is a stacked PR #1 (follows #1625): data-pipelines bundle ceremonies. `data-pipelines/README.md` file path fix in accordance to VEP 1507. Project and artifact bundle configurations added. Version of the cicd-expected ``@vdk/data-pipelines` release is 0.0.1. Proxy configuration set to the cicd-expected control-service instance http://cicd-control-service-svc:8092. Testing done: fetched the `frontend/shared-components` changes (from person/mdilyan/os-shared-components feature branch in review), and verified `frontend/data-pipelines` manual start + unit + e2e tests. --------- Signed-off-by: ivakoleva <iva.koleva@clearcode.bg> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontend config files were failing git pre-coming hooks due:
License insertion now covers TypeScript, JavaScript, (S)CSS,
HTML, Y(A)ML file types in addition.
PR titles can be now associated with "frontend" component.
Modified the pre-commit and gitlint configurations accordingly.
Testing done: installed the hook locally, and verified all
frontend/data-pipelines changes from multiple stacked PRs
were committed and auto-modified correctly
with the code header expected.