Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specs: Add user journeys to VEP-1507 #1750

Merged
merged 1 commit into from
Mar 21, 2023
Merged

specs: Add user journeys to VEP-1507 #1750

merged 1 commit into from
Mar 21, 2023

Conversation

DeltaMichael
Copy link
Contributor

No description provided.

@DeltaMichael DeltaMichael force-pushed the person/mdilyan/frontend-use-case branch 4 times, most recently from 541ddbb to 5befc8f Compare March 16, 2023 10:15
antoniivanov
antoniivanov approved these changes Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@antoniivanov antoniivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great. These are really well-written user scenarios. I'd use them as an example for future documents. Fanstastic job on that.

specs/vep-1507-vdk-operations-ui/README.md Show resolved Hide resolved
@antoniivanov antoniivanov changed the title docs: Add user journeys to VEP-1507 specs: Add user journeys to VEP-1507 Mar 16, 2023
@DeltaMichael DeltaMichael force-pushed the person/mdilyan/frontend-use-case branch from 00cfec5 to e3f612e Compare March 17, 2023 09:17
@DeltaMichael DeltaMichael force-pushed the person/mdilyan/frontend-use-case branch 3 times, most recently from 88a1456 to b79c322 Compare March 20, 2023 11:16
@DeltaMichael DeltaMichael mentioned this pull request Mar 20, 2023
Closed
zverulacis
zverulacis reviewed Mar 20, 2023
View reviewed changes
Copy link
Contributor

@zverulacis zverulacis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First thing, when I open the file on your branch, is VEP-NNNN: Your short, descriptive title
Please edit that.

zverulacis
zverulacis reviewed Mar 20, 2023
View reviewed changes
Copy link
Contributor

@zverulacis zverulacis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also suggest reviewing the whole doc with Grammarly or any other grammar correction tool. There are typos and also, formatting in some cases.

@ivakoleva ivakoleva added the area/frontend Related to changes in the folder projects/frontend for details about ui please see readme label Mar 20, 2023
@DeltaMichael DeltaMichael force-pushed the person/mdilyan/frontend-use-case branch 2 times, most recently from 6053652 to fef018f Compare March 20, 2023 15:04
ivakoleva
ivakoleva approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@ivakoleva ivakoleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVGTM 😊 Kudos, great use cases work.
I have a couple of comments, however it looks great and we should merge, and even get a broader feedback on the use cases.
This may require to distribute the link for some visibility, especially since a user facing feature and use cases are added. A lot of people already use the Frontend, and may have relevant feedback.

specs/vep-1507-vdk-operations-ui/README.md Show resolved Hide resolved
specs/vep-1507-vdk-operations-ui/README.md Outdated Show resolved Hide resolved
specs/vep-1507-vdk-operations-ui/README.md Show resolved Hide resolved
specs/vep-1507-vdk-operations-ui/README.md Outdated Show resolved Hide resolved
@DeltaMichael DeltaMichael force-pushed the person/mdilyan/frontend-use-case branch from fef018f to 216f998 Compare March 21, 2023 10:32
specs: Add user journeys to VEP-1507
6705a9e 
Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
@DeltaMichael DeltaMichael force-pushed the person/mdilyan/frontend-use-case branch from 216f998 to 6705a9e Compare March 21, 2023 11:56
@DeltaMichael DeltaMichael removed the request for review from zverulacis March 21, 2023 11:57
@DeltaMichael DeltaMichael enabled auto-merge (squash) March 21, 2023 11:57
@DeltaMichael DeltaMichael merged commit 8c935ed into main Mar 21, 2023
@DeltaMichael DeltaMichael deleted the person/mdilyan/frontend-use-case branch March 21, 2023 11:58
@exalate-issue-sync exalate-issue-sync bot mentioned this pull request Apr 4, 2023
Open
@exalate-issue-sync exalate-issue-sync bot mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoniivanov antoniivanov antoniivanov approved these changes

@zverulacis zverulacis zverulacis left review comments

@ivakoleva ivakoleva ivakoleva approved these changes

Assignees
No one assigned
Labels
area/frontend Related to changes in the folder projects/frontend for details about ui please see readme cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@DeltaMichael @antoniivanov @zverulacis @ivakoleva @vmwclabot