Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-core: Add 'method' to pre_ingest_process API #3072

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

doks5
Copy link
Contributor

@doks5 doks5 commented Feb 1, 2024

This change adds a method argument to the pre_ingest_process() and post_ingest_process()
APIs, in order to allow plugin developers to add logic specific only to certain ingestion
methods.

Testing Done: CI/CD

Copy link
Collaborator

@antoniivanov antoniivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. thanks.

@doks5 doks5 force-pushed the person/andonova/pre-ingester-api branch from ce98d5a to e49b4b2 Compare February 1, 2024 14:50
This change adds a `method` argument to the pre_ingest_process() and post_ingest_process()
APIs, in order to allow plugin developers to add logic specific only to certain ingestion
methods.

Testing Done: CI/CD

Signed-off-by: Andon Andonov <andonova@vmware.com>
@doks5 doks5 force-pushed the person/andonova/pre-ingester-api branch from e49b4b2 to 4e87eb6 Compare February 1, 2024 14:52
@mivanov1988 mivanov1988 enabled auto-merge (squash) February 2, 2024 08:02
Copy link
Collaborator

@dakodakov dakodakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mivanov1988 mivanov1988 merged commit 03dde45 into main Feb 2, 2024
9 checks passed
@mivanov1988 mivanov1988 deleted the person/andonova/pre-ingester-api branch February 2, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants