Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vdk-control-cli: Parse contacts with both comma "," as delimiter as well #719

Merged
merged 2 commits into from
Feb 21, 2022
Merged

vdk-control-cli: Parse contacts with both comma "," as delimiter as well #719

merged 2 commits into from
Feb 21, 2022

Commits on Feb 21, 2022

  1. vdk-control-cli: Parse contacts with both comma "," as delimiter as well 

    Until now we required contacts be separated by ";" semi-colon. This was
error prone as a lot of users are using "," comma and we are not really
preventing them so mails were written as "a@abv.bg,b@dir.bg" as if it is
a single email. T This also meant that people were not getting
notifications.

The fix is to add "," comma as allowed delimiter as a first step.
In a subsequent change we can add a email validator (like
https://pypi.org/project/email-validator)

Testing Done: unit tests including new ones

Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
    @antoniivanov
    antoniivanov committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    472dc21 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into person/aivanov/vdk-control-cli-fix-parsing-c… 

    …ontacts
    @antoniivanov
    antoniivanov committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    5915208 View commit details
    Browse the repository at this point in the history