control-service: improve api message on oom job execution errors #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
mivanov1988
reviewed
Jun 14, 2022
...lines_control_service/src/main/java/com/vmware/taurus/service/monitoring/DataJobMonitor.java
Outdated
Show resolved
Hide resolved
added 3 commits
June 15, 2022 16:35
mivanov1988
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why: Recently users of control-service have been complaining that jobs
which fail with User Error and have failed with an OOM error didn't
have a sufficiently clear enough message that classifies such types of errors.
what: Changed internal implementation so that when a data job fails due
to K8S OOM errors the message stored in the database contains a hint as
to the cause of failure - out of memory issues. We now explicitly check the
container termination message and in case of User Errors with an OOM error
we set an appropriate message.
testing: Refactored existing tests. Added new unit tests.
Signed-off-by: Momchil Zhivkov mzhivkov@vmware.com