vdk-core: make db_default_type case insensitive #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
requested review from
ivakoleva and
gageorgiev
and removed request for
ivakoleva
ivakoleva
reviewed
Aug 8, 2022
projects/vdk-core/src/vdk/internal/builtin_plugins/connection/impl/router.py
Show resolved
Hide resolved
ivakoleva
approved these changes
Aug 11, 2022
projects/vdk-core/src/vdk/internal/builtin_plugins/connection/impl/router.py
Show resolved
Hide resolved
It is a common error where you can set db_default_type=sqlite but because it's declared in the plugin as "SQLITE" we get error that no such db connection type exists which is not true. This PR changes it so that the db type check is not case sensitive Testing Done: unit tests Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
It is a common error where you can set db_default_type=sqlite but because it's declared in the plugin as "SQLITE" we get error that no such db connection type exists which is not true. This PR changes it so that the db type check is not case sensitive Testing Done: unit tests Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
antoniivanov
force-pushed
the
person/aivanov/vdk-core
branch
from
9c2a6e6
to
12c908b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a common error where you can set db_default_type=sqlite but
because it's declared in the plugin as "SQLITE" we get error that no
such db connection type exists which is not true.
This PR changes it so that the db type check is not case sensitive
Testing Done: unit tests
Signed-off-by: Antoni Ivanov aivanov@vmware.com