Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vdk-core: make db_default_type case insensitive #935

Merged
merged 2 commits into from
Aug 15, 2022
Merged

vdk-core: make db_default_type case insensitive #935

merged 2 commits into from
Aug 15, 2022

Commits on Aug 15, 2022

  1. vdk-core: make db_default_type case insensitive 

    It is a common error where you can set db_default_type=sqlite but
because it's declared in the plugin as "SQLITE" we get error that no
such db connection type exists which is not true.

This PR changes it so that the db type check is not case sensitive

Testing Done: unit tests

Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
    @antoniivanov
    antoniivanov committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    f96c1b5 View commit details
    Browse the repository at this point in the history

  2. vdk-core: make db_default_type case insensitive 

    It is a common error where you can set db_default_type=sqlite but
because it's declared in the plugin as "SQLITE" we get error that no
such db connection type exists which is not true.

This PR changes it so that the db type check is not case sensitive

Testing Done: unit tests

Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
    @antoniivanov
    antoniivanov committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    12c908b View commit details
    Browse the repository at this point in the history