-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci skip] Change 5-22-NFS-Volume Nightly test env from single esx to VC cluster #8021
base: master
Are you sure you want to change the base?
Conversation
|
||
$testbed = Proc.new do | ||
{ | ||
"name" => "vic-simple-cluster", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change the name to unique
"numMem" => 16 * 1024, | ||
}, | ||
"nfs" => { | ||
"name" => "dev-nfs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name should be unique
"memory" => 8192, # 2x default | ||
"disks" => [ 30 * oneGB, 30 * oneGB, 30 * oneGB], | ||
"nics" => 2, | ||
"mountNfs" => ["nfs.0"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't appear to exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe for this test we don't want the nfs mounted here, we do it in the test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I took this out.
"style" => "fullInstall", | ||
"desiredPassword" => "e2eFunctionalTest", | ||
"memory" => 8192, # 2x default | ||
"disks" => [ 30 * oneGB, 30 * oneGB, 30 * oneGB], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while we are here, might as well get rid of this. Don't need three small disks, just make one 50GB one or so
[Timeout] 110 minutes | ||
Run Keyword And Ignore Error Nimbus Cleanup ${list} ${false} | ||
Log To Console \nStarting test... | ||
|
||
${nfs} ${nfs_ro} ${esx1} ${nfs_ip} ${nfs_ro_ip} ${esx1_ip}= Deploy Simple NFS Testbed %{NIMBUS_USER} %{NIMBUS_PASSWORD} additional-args=--testbedSpecRubyFile /dbc/w3-dbc302/rashok/vic-nfs.rb --esxBuild ${ESX_VERSION} --esxPxeDir ${ESX_VERSION} --plugin testng | ||
${nfs} ${nfs_ro} ${vc} ${nfs_ip} ${nfs_ro_ip} ${vc_ip}= Deploy Simple VC Cluster With NFS Testbed %{NIMBUS_USER} %{NIMBUS_PASSWORD} additional-args=--testbedSpecRubyFile /dbc/sc-dbc1215/rogelios/vic-simple-cluster-with-multiple-nfs.rb --vcvaBuild ${VC_VERSION} --esxBuild ${ESX_VERSION} --esxPxeDir ${ESX_VERSION} --plugin testng |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should not wrap all of these variables up into additional-args... at most probably just the ruby spec file location var the rest are all standard and should be within the keyword
# Make sure the NFS deploy worked | ||
Should Contain ${out} ${name}.nfs.0' is up. IP: | ||
# Make sure the VC deploy worked | ||
Should Contain ${out} .vc.0' is up. IP: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just look for DEPLOYMENT => PASS or whatever. don't look for these specific things
Set Suite Variable @{list} ${esx1} ${nfs} ${nfs_ro} | ||
Set Suite Variable ${ESX1} ${esx1} | ||
Set Suite Variable ${ESX1_IP} ${esx1_ip} | ||
Set Suite Variable @{list} ${vc} ${nfs} ${nfs_ro} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to set all the esx here as well, otherwise they will leak
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I'll add that in... but just to make sure, passing in the ${vc} argument won't "include" the ESXs? @mhagen-vmware
Fixes #8013
We now have a test bed with a simple VC cluster with more types of nfs stores.
Group 5-22-NFS is now using this testbed.