Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci skip] Change 5-22-NFS-Volume Nightly test env from single esx to VC cluster #8021

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rogeliosanchez
Copy link
Contributor

@rogeliosanchez rogeliosanchez commented Jun 4, 2018

Fixes #8013

We now have a test bed with a simple VC cluster with more types of nfs stores.
Group 5-22-NFS is now using this testbed.

@rogeliosanchez rogeliosanchez changed the title [ci skip] Change NFS env from single esx to VC cluster [ci skip] Change 5-22-NFS-Volume Nightly test env from single esx to VC cluster Jun 4, 2018

$testbed = Proc.new do
{
"name" => "vic-simple-cluster",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the name to unique

"numMem" => 16 * 1024,
},
"nfs" => {
"name" => "dev-nfs",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name should be unique

"memory" => 8192, # 2x default
"disks" => [ 30 * oneGB, 30 * oneGB, 30 * oneGB],
"nics" => 2,
"mountNfs" => ["nfs.0"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't appear to exist

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe for this test we don't want the nfs mounted here, we do it in the test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I took this out.

"style" => "fullInstall",
"desiredPassword" => "e2eFunctionalTest",
"memory" => 8192, # 2x default
"disks" => [ 30 * oneGB, 30 * oneGB, 30 * oneGB],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while we are here, might as well get rid of this. Don't need three small disks, just make one 50GB one or so

[Timeout] 110 minutes
Run Keyword And Ignore Error Nimbus Cleanup ${list} ${false}
Log To Console \nStarting test...

${nfs} ${nfs_ro} ${esx1} ${nfs_ip} ${nfs_ro_ip} ${esx1_ip}= Deploy Simple NFS Testbed %{NIMBUS_USER} %{NIMBUS_PASSWORD} additional-args=--testbedSpecRubyFile /dbc/w3-dbc302/rashok/vic-nfs.rb --esxBuild ${ESX_VERSION} --esxPxeDir ${ESX_VERSION} --plugin testng
${nfs} ${nfs_ro} ${vc} ${nfs_ip} ${nfs_ro_ip} ${vc_ip}= Deploy Simple VC Cluster With NFS Testbed %{NIMBUS_USER} %{NIMBUS_PASSWORD} additional-args=--testbedSpecRubyFile /dbc/sc-dbc1215/rogelios/vic-simple-cluster-with-multiple-nfs.rb --vcvaBuild ${VC_VERSION} --esxBuild ${ESX_VERSION} --esxPxeDir ${ESX_VERSION} --plugin testng
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should not wrap all of these variables up into additional-args... at most probably just the ruby spec file location var the rest are all standard and should be within the keyword

# Make sure the NFS deploy worked
Should Contain ${out} ${name}.nfs.0' is up. IP:
# Make sure the VC deploy worked
Should Contain ${out} .vc.0' is up. IP:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just look for DEPLOYMENT => PASS or whatever. don't look for these specific things

Set Suite Variable @{list} ${esx1} ${nfs} ${nfs_ro}
Set Suite Variable ${ESX1} ${esx1}
Set Suite Variable ${ESX1_IP} ${esx1_ip}
Set Suite Variable @{list} ${vc} ${nfs} ${nfs_ro}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to set all the esx here as well, otherwise they will leak

Copy link
Contributor Author

@rogeliosanchez rogeliosanchez Jun 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I'll add that in... but just to make sure, passing in the ${vc} argument won't "include" the ESXs? @mhagen-vmware

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants