Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timelens incompabilities with relive player #420

Closed
saerdnaer opened this issue Oct 25, 2019 · 7 comments · Fixed by #472
Closed

Timelens incompabilities with relive player #420

saerdnaer opened this issue Oct 25, 2019 · 7 comments · Fixed by #472
Labels
css javascript player

Comments

@saerdnaer
Copy link
Member

saerdnaer commented Oct 25, 2019 •
edited
Loading

Der Clappr Player auf media.ccc.de bräuchte noch eine Fall-Unterscheidung damit er bei nem Relive Video nicht das Timelens Modul läd – aktuell überdeckt die leere Timelens extension die eigentlichen Thumbnails des Players:

image

Related: #363

During Saturday you can test this with the newest recordings (without timestamps) on https://media.ccc.de/c/wikidatacon2019?sort=date
@saerdnaer
Copy link
Member Author

saerdnaer commented Oct 27, 2019 •
edited
Loading

According to @derchrisuk this has nothing to do with the source code, maybe only an CSS issue?

TODO: create a new test event which has not yet final recordings... Maybe for privacy week?

@saerdnaer saerdnaer mentioned this issue Oct 27, 2019
Closed
5 tasks
@saerdnaer
Copy link
Member Author

@blinry Did you have a look at this?

@blinry
Copy link
Contributor

blinry commented Dec 23, 2019

Not yet, and I'm not sure whether I'll be able to squeeze this in before 36C3. Is there currently a place where this problem could be reproduced?

@saerdnaer
Copy link
Member Author

Hmm, we probably have to wait till 36C3 starts :-)

@saerdnaer
Copy link
Member Author

@blinry Here is a test case for you: https://media.ccc.de/v/36c3-10892-schweiz_netzpolitik_zwischen_bodensee_und_matterhorn

@saerdnaer
Copy link
Member Author

@blinry Die DiVOC Mitschnitte sind aktuell auch noch größtenteils ReLive's: https://media.ccc.de/c/divoc

@saerdnaer saerdnaer changed the title Disable timelens for relive player Timelens incompabilities with relive player Jul 11, 2020
blinry added a commit to blinry/voctoweb that referenced this issue Jul 17, 2020
@blinry
Undo Timelens styles for Clappr players inside of relive-player classes.
0cb0db2 
To avoid this, we would need to set it up in a way so that timelens.css
is only loaded for pages with a Clappr player where a visual timeline is
desired.

Fixes voc#420.
@blinry blinry mentioned this issue Jul 17, 2020
Merged
@blinry
Copy link
Contributor

blinry commented Jul 17, 2020

Thanks for poking me to take a look at this again, @saerdnaer! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css javascript player
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Undo Timelens styles for Clappr players inside of relive-player classes. blinry/voctoweb
2 participants
@saerdnaer @blinry